From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Bw0XF5BLwWlMvDUAWB0awg (envelope-from ) for ; Mon, 23 Mar 2026 10:17:52 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=lNKH4cNb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4F1761E04F; Mon, 23 Mar 2026 10:17:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E05E21E04F for ; Mon, 23 Mar 2026 10:17:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4148B4BB3B8A for ; Mon, 23 Mar 2026 14:17:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4148B4BB3B8A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=lNKH4cNb Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 47A804B97005 for ; Mon, 23 Mar 2026 14:17:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47A804B97005 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47A804B97005 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774275445; cv=none; b=gr7GSGps/Bl2J9ACU0kHZvC/IjmNT/lZMG5z8Tdx/ktCtLwhL2rFDYOIGw7VRuaSrLrkPuA3kjkWQVcWmPATGaYSjHTPqP7EvSzol1B3Rdy0jhPwE7w6TIVundMwTkQRMlXEWu9LF/SzAZJNEcNs5Km4KBwRk8/szirYdvBpipQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774275445; c=relaxed/simple; bh=qSgRAwPizOUQAA9Dz3YI3DL6NBU9fglmpy2In3asMas=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Vwo/dBtqWkDfJXo0v74WAYXr6rScoPhgb4P4GzxOQrvHTG5Sraaix6jCoHhKEC7vaITAL8RQP0LBm0/XlF2wK7IgCdA5cWiy1NUEr4xbYrU0240SPAmP0kz5peLj4NJiASdrDQD0W+rp0xqArVE/hbXb/bTYrkq8wzbw6V79Phc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47A804B97005 Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id 4dwzwozW3Kjfo4g5swKZmS; Mon, 23 Mar 2026 14:17:24 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4g5fwsZ3JOs9R4g5gwlK0e; Mon, 23 Mar 2026 14:17:12 +0000 X-Authority-Analysis: v=2.4 cv=HPPDFptv c=1 sm=1 tr=0 ts=69c14b73 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=QVH9OI_R7b1qq6gz3_oA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=otRflSkqXKGT3XuST7ePHwiSJ66XRD42ZqqAwBxsamU=; b=lNKH4cNb6V0RivB02lckxFI2AJ ckEID2850TgJl3GfiQ0McDPfRqaUXNm8YKtyrQ/gSCbTexNtG07tYoIKeSHymHZv5PiWnGn8T82Cl kRqITfmyZhuSbr/9uS6eZKQGI; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:36892 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w4g5f-000000006e7-1DWB; Mon, 23 Mar 2026 08:17:11 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdbsupport] Poison ctype.h / cctype functions In-Reply-To: <20260322160338.3224997-1-tdevries@suse.de> (Tom de Vries's message of "Sun, 22 Mar 2026 17:03:38 +0100") References: <20260322160338.3224997-1-tdevries@suse.de> X-Attribution: Tom Date: Mon, 23 Mar 2026 08:17:07 -0600 Message-ID: <87jyv28wbg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w4g5f-000000006e7-1DWB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:36892 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDASnN5J0dK9awqX86Jv7ZriQxErj5Bvz1x1GY8hvDCKAEqQy8r2LGzx2FwyQ5lwgRUuRzExBLFaQJovvJygfGgFZA/ml7+Wmxh2PRDIdjwG0gN5pS5A 2fYX+mqZpxhGD6yxugihqm478xnyKYPV8zGpBC4vTC2sb4OaSirV9rt6k/JztM4qKnSJoIjIFSuEFj0nfhhSfbbJthLnSxjXpt8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> GDB generally uses c_isprint instead of isprint or std::isprint [1]. Tom> Poison uses of ctype.h / cctype functions in gdbsupport/poison.h. Tom> This excludes isupper, islower and toupper because they're currently used in Tom> GDB. Add a fixme to find out whether these exceptions are ok, and if so Tom> document why, otherwise fix them. Tom> +#define POISON_CCTYPE(F) \ Tom> + template \ Tom> + F \ Tom> + { \ Tom> + static_assert (false, "Please use gnulib's c-ctype.h"); \ Tom> + return 0; \ Tom> + } Tom> + Tom> +/* Poisoning of some functions is disabled: Tom> + - isupper, because it's used in ada_decode. This is just an oversight. Tom> + - islower and toupper, because they're used in UNCTRL from readline, Tom> + which is used in tui_redisplay_readline and gdb_fnprint. Can't really touch readline but we could write our own UNCTRL variant. Tom> +POISON_CCTYPE (int isalnum (T c)); Tom> +POISON_CCTYPE (int std::isalnum (T c)); I suspect redefining standard functions like this is not allowed in C++. Tom