From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bvvvAzV+3mk7PxcAWB0awg (envelope-from ) for ; Tue, 14 Apr 2026 13:49:41 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AXH1HN1s; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F2C451E0C3; Tue, 14 Apr 2026 13:49:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 51CA51E04F for ; Tue, 14 Apr 2026 13:49:40 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D30694BA23DA for ; Tue, 14 Apr 2026 17:49:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D30694BA23DA Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AXH1HN1s Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 21CEB4BA2E07 for ; Tue, 14 Apr 2026 17:49:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21CEB4BA2E07 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 21CEB4BA2E07 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776188956; cv=none; b=DfHRRNDG2vy5aJKlu97UItogx7h+4ECluSoxCG20sVlD2g9z8cwKDZCEg3E4MWUK22WcaXj8OHRrefb7VhtyE3cWw7BCUDDVbfCOC8Cq+k3rnEt3La4Jp5agFYynnrknApBa7AkkkSlkleW14oPo9jwMdUQefI+PRbl8FddGOM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776188956; c=relaxed/simple; bh=tD+r/2eNEKjs7XMEk9K22RJArObO4Oqo+vrzGBIiZfk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ctIDGeB4MXv9iff5DRUdQk8SeIgQ3FsWI2TTi/SEMP3XQk9PXMdgJMCtQpI98zcHW0OdgKlzQoCKDFqADRx7r06Ou+CoW+kEyXHpEbKbw/B9su/8GZIgczw19ogwkHBqtWca4L9Z/ZYGPagHHFFbyrTOhAIZnx26JQ/DZY0WiF0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 21CEB4BA2E07 Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id ChnBwk0ZMObRfChsxwXmGB; Tue, 14 Apr 2026 17:49:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id ChswwDMTiYA8xChswwaiQL; Tue, 14 Apr 2026 17:49:15 +0000 X-Authority-Analysis: v=2.4 cv=VJfdn8PX c=1 sm=1 tr=0 ts=69de7e1b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=IfqENSGkPeHtRSUhP8EA:9 a=vsCvvem9CHYA:10 a=6KDmPahKW5ILxopYhpMU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YUcQhcPXVkxZPezcVhyHRmWVvMJZeU/PW2cQH/nN1Mg=; b=AXH1HN1s5CkfF3cjT9Jh4WxJ46 WHibJip5+H3ifCqtkWap8qHJPs1U7Yr6wMPA4yx0dkzOX0xbgY6lvqMrgpgMRnQeo1tz944e051dW /zAFsAxLKGR7Fs0SGlQ0JufFg; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:47846 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wChsw-000000022H7-1p2e; Tue, 14 Apr 2026 11:49:14 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 1/2] [gdb] Break up complex assignment in cp_lookup_symbol_via_imports In-Reply-To: <20260410121144.1836026-2-tdevries@suse.de> (Tom de Vries's message of "Fri, 10 Apr 2026 14:11:43 +0200") References: <20260410121144.1836026-1-tdevries@suse.de> <20260410121144.1836026-2-tdevries@suse.de> X-Attribution: Tom Date: Tue, 14 Apr 2026 11:49:13 -0600 Message-ID: <87jyu9v3dy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wChsw-000000022H7-1p2e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:47846 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfISnJn3fN0XMqr7ytyjsOskmEEJPauKXUmb9S2pPhX9UB1fZjmThO9aK7y6e7coRFr9dCX3ENBvO5TnNYMNmvJg8r0rm1FKxWqzDFZMFxDAMAz8namCp sFInbVNM6AsgWoC5Jerl8FMsyrw94FLuiEqWcXeM2Wd/MzJGiRTRjmyAO5U0v2fyCFFmF5xx+GuQkAr5axztPJDDoLPtwNyBV3Q= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> + if (len == 0) Tom> + directive_match = 1; Should be "= true". Ok with this tweak. Approved-By: Tom Tromey Tom