From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2VoSOFyj9GkEBQkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 08:58:04 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=i29oGqRw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DEDDE1E0BA; Fri, 01 May 2026 08:58:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7CBDE1E067 for ; Fri, 01 May 2026 08:58:04 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 0ADF746A9CDB for ; Fri, 1 May 2026 12:58:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0ADF746A9CDB Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=i29oGqRw Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 847BF46A9CDB for ; Fri, 1 May 2026 12:57:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 847BF46A9CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 847BF46A9CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777640258; cv=none; b=tYF7Pu5x8GRhGkdnJEFw6pZD5O9oo7oJN9/lfiG4qRVv0zFRjMr9s1BIJXX3Ksf2vpzdylXfqvpTzlSeHON0Z05EgZNb9kOTUwJifuPWFNkj9ImciQAAWfEODCSshNoOma7fsTo1igab/w6dn2qqcYSOLrSNFq3WGev4J8fM+NM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777640258; c=relaxed/simple; bh=uFOJXHkYTctASEHXPy1DDtwEXoMMmItG71xD7XrkXc0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XPUivJR7X2aH3h3LCWVBtEu9yha0LbWBYiztNE3bkp7Tb24GqlKHvQ4K4Z9l2S1xUTgSbIchj46W/avIEKhnLu5w8ZI7X/OCZGyZpu/H8whe94V5pXBxL46n8kZ5Oy9u55t8i1a0kqWsG+6NuEAiMOcWyEiTnZdwNsbOXWAxX1c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 847BF46A9CDB Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id IZQQw6iy5nwj2InR3wonWU; Fri, 01 May 2026 12:57:37 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id InR2wId23I7vWInR2weymR; Fri, 01 May 2026 12:57:37 +0000 X-Authority-Analysis: v=2.4 cv=T6WMT+KQ c=1 sm=1 tr=0 ts=69f4a341 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=tfWaO0x1q06znJLnR-wA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4Nl3KkvWMWYLq6DKN8bRIlw96UATQGmAQHRawaMb5h0=; b=i29oGqRwqdUSJxTSIveiAd8dth cfD1YL5Kg8cH7Rxi+VcWJOWPguTVvfhbESk+b3s58vZ7UgOnAisi2zyUj+YJ2IkVE0sq5/yymtF0R QxTM2dZWUSN9+j17HFL/1aflc; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:58860 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wInR2-00000001gaK-2lXV; Fri, 01 May 2026 06:57:36 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] [gdbsupport] Factor out base_next_iterator In-Reply-To: (Simon Marchi's message of "Thu, 30 Apr 2026 15:09:24 -0400") References: <20260423063530.1074175-1-tdevries@suse.de> <20260423063530.1074175-4-tdevries@suse.de> <52ebd2ce-a27b-4cf6-81f4-ad3fa3537ee1@simark.ca> X-Attribution: Tom Date: Fri, 01 May 2026 06:57:35 -0600 Message-ID: <87jytni8xs.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wInR2-00000001gaK-2lXV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:58860 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfM+h+39DSVrEYrtaw+Tcg9/eC2ExrOuK657Xi53yFU4VSTp+fAs4CwQ7v/GsFpnY+4ejMmNoRksC8+RhzqZnQ8TQtx4q/QygN3EVJGzMfGHwvxQ6CAPH QGa0QxCq78PvMfMGz3WlUBtBOs24q1G7rkrNB6VX7cpCQXRXmvy72OIqU5QVhVBX4QP6ATiIq5+lgMIWNv8FPeGNLBd906PgFsQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> The only caller is in ada-lang.c, it passes the result of Simon> get_frame_block(). I guess that a block from a frame is always in a Simon> function (is not the global or static block), but if that assumption Simon> isn't true, then a check would be needed in the caller. I think it would be a bug if a frame's block were the static block, but OTOH we had to preserve that hack in the blockvector lookup code, so who knows. Tom