From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +R6+NBdAT2owSS0AWB0awg (envelope-from ) for ; Thu, 09 Jul 2026 02:30:47 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bAKRql6p; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D3ED81E098; Thu, 09 Jul 2026 02:30:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 653561E04F for ; Thu, 09 Jul 2026 02:30:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70C3B4BA2E38 for ; Thu, 9 Jul 2026 06:30:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 70C3B4BA2E38 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bAKRql6p Received: from mail-yx1-xb12d.google.com (mail-yx1-xb12d.google.com [IPv6:2607:f8b0:4864:20::b12d]) by sourceware.org (Postfix) with ESMTPS id 0CE554BA5435 for ; Thu, 9 Jul 2026 06:30:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CE554BA5435 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0CE554BA5435 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783578623; cv=none; b=RCwT5vEsrmLfEsYYzgVErX2NHtVFqgPEqfKPQiQ+1tJ11c6Mn2sMobRJwudmmQLSJGtLl6uKoQTwbf1l/X923mkuxyOuX/rRjnATbxqGAhi92Wy4nTZj4uzTKAY++SJkjRRS1N2W4VZYL1YtU/LEY06jwtyIKOo0oZXEMvN9l1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783578623; c=relaxed/simple; bh=PnRBHijejAh+Zd2XU5wke4JrbZCcsMjs7fvvHodkNlw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bVHOCwZoFnIpr+HpChQhr9YmiTH1F2mmp3Mca3he1n12DPQnMLqX++8kopXjl5zvhX9u9jD1wjHIhLYzlnaWZ0JWzq2dR725Z4jGDto0U4jPjx2QiQc1WfWNzFZYC4mrjUjb0QmPGGx3wES4xNnLMIHIyoo7+6u99dfXzE4NDHA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bAKRql6p DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CE554BA5435 Received: by mail-yx1-xb12d.google.com with SMTP id 956f58d0204a3-664db84f074so1853321d50.0 for ; Wed, 08 Jul 2026 23:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783578622; x=1784183422; darn=sourceware.org; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=8X5gl7gb2RqCJqnc0QxZjIem+f9qkpB5pp/Ofrbki/s=; b=bAKRql6pMS3Wnqhjs7e9Iu45Ywg9HpIzZ2i6Bqo9KJqQMv8ScuzcWLEdI/PLCWIIFl C2gUWR0w9GUrNdyJOAO3oaf2beRhN7myK2lwV6PwOm73N18a7dAxsIZXZOiP/TDV+ZP/ l4anhN9bCfxK6Di85GfxDD8Eoegjo15TcC/dq+1HDeuhy2tzXNNv46VJUnPKOMMYzceX 0An2U7GbPPOLyMgllwlMHykGu9ACVP0AZuDUG5YI7w5TJMFvFrdbbS8TbrgTNlaHdLuM I6apS5irGr7wx2799nlBS0pO8L0AiA7756OMFam1ATwLev78AAfo8vsli5hpqxuN1shl WArg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783578622; x=1784183422; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=8X5gl7gb2RqCJqnc0QxZjIem+f9qkpB5pp/Ofrbki/s=; b=Xxj7at0S3gA7moyOIAxNbRoqMIuzT7lPsWGqnPGR3jUCaaiJZ9u9twznDKLnXE6YnE as23PPgeoXGHh/mdudQW7dOrAefnbc18kQj4LtD055lD80bDDiHfvlaxZOfQOdPN59x6 4oAxhsPpWMU5gPZL6y7ntmf46mk5FwarXZJ+g9bGSVfY2ZDFjsKkcmgKiPgdzom5SVSa 0bt8Wn2K4rffIzdTu0yqS7L+dyiyhTfQ8odvyWjI6larixG3z4UAp8TVGo5huUXFmtpe HAXstdzYILttF5UEqUzks4APzVbMtWs4EMlgzD9MZhvH63Ntw/4P8DAS6Iii57yHf1FM QBiQ== X-Gm-Message-State: AOJu0YyOvWyWV90vB9o4YdPlwyEc0hNg/1j0cbVGQMfVww5FgfOELC/Y aBV7aYs23/VcT8m9z5mJhaS80dU5dxceVbQo6NfUISqthT+ZPks/JXwMHHdXlT6M4ac= X-Gm-Gg: AfdE7cnlr71RD7JiC0a+Dk1Byo9w/G+52Kw2UytStXHUQ0T3W+xETZNcn4Q3MLAowWh e01uy5ft2aaHAkGk9CUgFGT9fWvsXSIsOSJWeUB3WPw6N5cs2QGsmCpJsO8TBz5XvJiu5I8t5Iq kA8IEQrUO8b4z1j0WLQj4YJolPaDh7+M4sh0/szyJjGH6++yQmcc2+UM97YrKF1dD7v4LWhaigG IPz9ygdf92psbZ0WEr4uyrud0K/hGqrvZjQdWff2qLG432ldpmwMMXMjBuxRtJw6pQzyZeXZoWd wVyWjE6joM0PCfzWx2dvSa6tG7Oqz6zPkNPfVmzdOrVYZxPHneMzcutS0babH3QiywrhArBjKUi IXnPx0E36P4Ih6Xdn5iqf2rY+MOB02YotQ0eO/iBTbgEvCGxgoh25J9awGkze3APYz5aKjVI9gS 225StfohcixQKPFeoespbYncA= X-Received: by 2002:a05:690e:4008:b0:667:a12c:8214 with SMTP id 956f58d0204a3-667a12c87aamr3842552d50.2.1783578622248; Wed, 08 Jul 2026 23:30:22 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81e6bef1bdcsm10705627b3.12.2026.07.08.23.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 23:30:21 -0700 (PDT) From: Thiago Jung Bauermann To: Matthieu Longo Cc: , Luis Machado , Luis Machado , Andrew Burgess , "Yury Khrustalev" , Pedro Alves , "Tom Tromey" Subject: Re: [PATCH v1 03/10] target_fileio_read_stralloc: add an optional length parameter In-Reply-To: <20260707154900.94542-4-matthieu.longo@arm.com> (Matthieu Longo's message of "Tue, 7 Jul 2026 16:48:53 +0100") References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-4-matthieu.longo@arm.com> User-Agent: mu4e 1.14.2; emacs 30.2 Date: Thu, 09 Jul 2026 06:30:19 +0000 Message-ID: <87jyr41xqc.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Matthieu Longo writes: > diff --git a/gdb/target.h b/gdb/target.h > index 22653138491..4215553033c 100644 > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -2336,7 +2336,7 @@ extern LONGEST target_fileio_read_alloc (struct inferior *inf, > are returned as allocated but empty strings. A warning is issued > if the result contains any embedded NUL bytes. */ > extern gdb::unique_xmalloc_ptr target_fileio_read_stralloc > - (struct inferior *inf, const char *filename); > + (struct inferior *inf, const char *filename, size_t *len = nullptr); It's worth updating the documentation comment to mention the new parameter. > > /* Invalidate the target associated with open handles that were open > on target TARG, since we're about to close (and maybe destroy) the -- Thiago (he/him)