From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2jVpMTG4X2qhSyEAWB0awg (envelope-from ) for ; Tue, 21 Jul 2026 14:19:29 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jnOf3fud; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B6EB41E033; Tue, 21 Jul 2026 14:19:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 22BE41E033 for ; Tue, 21 Jul 2026 14:19:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2C05F4BA2E0B for ; Tue, 21 Jul 2026 18:19:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C05F4BA2E0B Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jnOf3fud Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 61AA14BA5439 for ; Tue, 21 Jul 2026 18:19:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 61AA14BA5439 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 61AA14BA5439 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784657943; cv=none; b=cPwQIjFonmHB6xp4rPlfPFv00jBBbJuUsxrL1vrGZX76SwpD0ysmGvPe68qJ3Uc8uad/Ms6Gl4zPN6tQ3HfDPfHdagIMJlXReAeHGFj2m3GWDKuZ3S3m6SPs5e/4rau4dsNWp+EVFxz4NZ29+RN5wuWnn4SoD34R5wTaGYwzhwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784657943; c=relaxed/simple; bh=lxvvn+7cO1Kp2dHcew+Fy4Oe8wxamNNtmKn38aR3GFM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fvphs3qXAM6oqXwVF4/dzvw4cXqlkPCOQ/JyCGeuIIZFYMJYY/2okJv2eTNhrgnbf9Qt9oE725t7n7PO01S/QeUqZna7DDYHRwNPQAkJ3OLgoSdeUVMCYSbrz87o3mUvWrAAxV5PxuEdSi8XFJna1T2z5vb0Ldar4xbbhQnXrvU= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jnOf3fud reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 61AA14BA5439 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id mDlCwESqZQ4O6mF3Wwxzt3; Tue, 21 Jul 2026 18:19:02 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id mF3WwVOUFooyImF3WwtFjt; Tue, 21 Jul 2026 18:19:02 +0000 X-Authority-Analysis: v=2.4 cv=AZ6xH2XG c=1 sm=1 tr=0 ts=6a5fb816 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=RAioF0-LDSMA:10 a=ItBw4LHWJt0A:10 a=zd2uoN0lAAAA:8 a=crhawG-963FGZ8jTr7QA:9 a=O8hF6Hzn-FEA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jpA5ejiyKXlgX0tEIxL0y5B4pqtE9P5N129zZmZNZfQ=; b=jnOf3fudBwrmn7Qz+98pjBUBwU JEEKiimu6uHOZnI6sbFVdtIFSFgEFYjcsVhxCrjZGjLq77pNdwePUPFpatH9R7eom3ubT2gSikwOA 2VrfYq3rF4O3SZeDXbMplh6Rv; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:43602 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wmF3W-00000003Q6T-0M5T; Tue, 21 Jul 2026 12:19:02 -0600 From: Tom Tromey To: Tankut Baris Aktemur Cc: Subject: Re: [PATCH 04/16] gdb: convert address_class_type_flags to address_class_dwarf_to_id In-Reply-To: <20260713-users-aktemur-type-instance-flags-v1-4-779cad0c85ec@amd.com> (Tankut Baris Aktemur's message of "Mon, 13 Jul 2026 09:00:03 -0500") References: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> <20260713-users-aktemur-type-instance-flags-v1-4-779cad0c85ec@amd.com> X-Attribution: Tom Date: Tue, 21 Jul 2026 12:19:01 -0600 Message-ID: <87jyqotdd6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wmF3W-00000003Q6T-0M5T X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:43602 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIYpXUamAbzW3b0OsOzH0nateq27DohYt+v9HLpuHJnCLvrGP9PU9/bNjJE59rWSdq/oZLU7EQ5reMfd0gZhNnDSYy4G5YTU3TwXftw4dfrhD6/7vC7q xR9ghk9V4IY9cbUnQnAuNUvoZRDfSt/o6xjGh5c73qFL6xmy3ly8/B9IG2CrijuA8cO+/OcTJMP4aOZ8uXQTH7/HR0/riWJzBi4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Tankut Baris Aktemur writes: > The gdbarch method 'address_class_type_flags' is used for letting an > architecture translate the DW_AT_address_class attribute to an address > class id. Make this clear by refactoring the method to return an id, > instead of a whole type instance flags value. There is hardcoding of > "<< 4" left in dwarf/read.c. This will go away in a future patch. Thank you. > Function( > - type="type_instance_flags", > - name="address_class_type_flags", > + type="unsigned int", > + name="address_class_dwarf_to_id", > params=[("int", "byte_size"), ("int", "dwarf2_addr_class")], > predicate=True, > ) Would you mind adding a 'comment' field here? thanks, Tom