Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tankut Baris Aktemur <tankutbaris.aktemur@amd.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] gdb, dwarf: update code style in read_tag_pointer_type
Date: Thu, 30 Jul 2026 10:26:43 -0600	[thread overview]
Message-ID: <87jyqcqw8s.fsf@tromey.com> (raw)
In-Reply-To: <20260728170746.1037942-1-tankutbaris.aktemur@amd.com> (Tankut Baris Aktemur's message of "Tue, 28 Jul 2026 17:07:45 +0000")

>>>>> Tankut Baris Aktemur <tankutbaris.aktemur@amd.com> writes:

> Update the code style in read_tag_pointer_type to match current
> practices.

> The declared type of `byte_size` is changed to ULONGEST because we are
> reading an unsigned constant.

Thanks, this is ok.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

      parent reply	other threads:[~2026-07-30 16:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 17:07 Tankut Baris Aktemur
2026-07-28 17:07 ` [PATCH 2/2] gdb, dwarf: update complaint logic " Tankut Baris Aktemur
2026-07-30 16:38   ` Tom Tromey
2026-07-30 16:26 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jyqcqw8s.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tankutbaris.aktemur@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox