From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ubaMGMGCvmqxVyQAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 11:56:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cAwkEsqt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 59B4F1E051; Thu, 01 Oct 2026 11:56:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D12AE1E01F for ; Thu, 01 Oct 2026 11:56:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 966614BB1C2A for ; Thu, 1 Oct 2026 15:56:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 966614BB1C2A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cAwkEsqt Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 91EF24BA2E04 for ; Thu, 1 Oct 2026 15:56:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 91EF24BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 91EF24BA2E04 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790870183; cv=none; b=aaxmYB8LUppHnoTU9PksKfLz6owLUhgOVg8wG5E8IwPohcSpggtscg+tTb+WEmrFsn3uLkozHn7Hg2QXD1HiccUwm5dqOc0clsglh/tQ/yjVJLmlEw9/RdV38M89TNqyuA303iuirQqQUtnGV6haKfyFlBt95vGG6BQo88S3HTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790870183; c=relaxed/simple; bh=YLKhRe18u4o+BIE2Kh/XSQqhJwZkHtn70iYTYuUQfxY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=x3mKetIoqDnThZIaA++EqmOEQ0TiilVAlqWPWJRG1GqZCN5qx20PUUg+EepX95k5Lmfo4cJQ/aH+6F9TW7AawP8Nvbe8blGpw7wXx3Wo7mTy8Cv+frwXaaR1ExyQ7q821Izd1lIz/562WemOMdnN9Vb+GxFkfSwFb7hEISaNXtk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cAwkEsqt DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91EF24BA2E04 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790870183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ExV/PFRxOEd9TciXuH3RF0BEsz2qOl7XtxQ3ulZq4F8=; b=cAwkEsqtpnyOP2Z4ib4izkRL53K8FKOCXL1oBur+G7r+ZNfqYuPa57+GvXjptIoz1BLdeE RrkGLOXPLORaGZFKMqy0m9inPYxvz9pWgXra01w8bp+Nzpes/IQGabEnK1MiAA2yY/aQvU +NgI1tsf7mWASajnQyxnnPzf6Y0yBok= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-t8go8zFYO8q10LsY1epLMQ-1; Thu, 01 Oct 2026 11:56:21 -0400 X-MC-Unique: t8go8zFYO8q10LsY1epLMQ-1 X-Mimecast-MFC-AGG-ID: t8go8zFYO8q10LsY1epLMQ_1790870180 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a020cf06c3so5567865e9.3 for ; Thu, 01 Oct 2026 08:56:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790870180; x=1791474980; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ExV/PFRxOEd9TciXuH3RF0BEsz2qOl7XtxQ3ulZq4F8=; b=Jq2co0MgXbvutePFltgWj266/GrjPqcQDO74lIsrlwm0Jv+o9QqS3rPic1yJnhi1B0 0rNngWvu1MwgOUKwRtVLwKwopq3GCCtR834ccaXaZ8lNzqvq6tU+Rh8LRWr/m901Au8H 0JRB70pRGB3OgNeWHgF9BpffH8GPAK8FTh1HJpmsHvh7pWNf2jQPm98NdSOuU+Dqe0kf zVpNVdLNk6+/TlhMUeFFlQM4ecxmm1A+imBDjHCevZONiU6JXv+k7T2bIToFfa59jEgn sMbdvRcDeiKDl+9rvC3SZqNrO+qA4I+yBSWlseIDYUaaQWFaXOn8x7WpAJVPupRWh7Mj xrWA== X-Forwarded-Encrypted: i=1; AKwUvBxfC1yCgMD/Huao9NnF4GOIkYbIvQuCbhT7Z2n8YlCsNbTxrf3tLvfsQkPgdQJINKgOQHRsok/8buIVMA==@sourceware.org X-Gm-Message-State: AFuF++kS3GJd2d1TKEf6xjMghJjGuQKOcm7NsecEW7Efbu7qytXvYPz3 5S7s+dne0wS60mqTVgb0IcbizCEfhyI4HQMYuP7F5R7mGZFSrzLctQamA2yw9J3zR2ya7oSsemI QkRiwl2kTscmGsNXJ48iIiE0g0oOJJgiYZlG7gVxObjgAzPgjHsyY+OZRIe25FF6VCsGqxB0= X-Gm-Gg: AYBFou13T1wpl0VZ2B6+B3Swi3t5ewiltsYfWDApb0g7Vbao/hxs3Co2Q+iF+9vzFsm 4CBF3JmUkWceMWcTEBIFxFnygM/yTjHv1FBIA6cTTg4vRMQ+1nvzbEZzQI4p1K+JNU/IOEcmf0O 2Pvo9YJR0/9FID+B1sSH1N0SilOE8sU1Tra27Mee6xTm8Y7qeZN/aG2P30AZM/QMu0X7vsvLxn/ t78Ey0ozCvaOtTxs9mcZNe+CW3tPyTPH2OdaCMfMVz9RRqO+nzaFl3MLDdMZYL353fc5O3dI/ei u07nq/FCUqH8j89mSj7Zu8dq4Lq20GE4wyloDfwT4bWaQz/DnOxrQIoPDazmK70rph3g X-Received: by 2002:a05:600c:34d6:b0:4a0:1d1a:6067 with SMTP id 5b1f17b1804b1-4a0276ba3f4mr538995e9.34.1790870180323; Thu, 01 Oct 2026 08:56:20 -0700 (PDT) X-Received: by 2002:a05:600c:34d6:b0:4a0:1d1a:6067 with SMTP id 5b1f17b1804b1-4a0276ba3f4mr538725e9.34.1790870179939; Thu, 01 Oct 2026 08:56:19 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a027698f13sm887985e9.1.2026.10.01.08.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 08:56:19 -0700 (PDT) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH v2 11/11] gdb: fix some comments in global_symbol_searcher In-Reply-To: <20261001020952.698419-12-simon.marchi@polymtl.ca> References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-12-simon.marchi@polymtl.ca> Date: Thu, 01 Oct 2026 16:56:17 +0100 Message-ID: <87jyo1xvmm.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sgXbDWHTRA188SUNR4Le8dEslsqYyznrBkRC42ECSIc_1790870180 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > Fix a few comments in and around global_symbol_searcher: > > - The comment of global_symbol_searcher::m_exclude_minsyms refers to > M_SYMBOL_REGEXP, which does not (or no longer) exist. It means > M_SYMBOL_NAME_REGEXP. > > - The comment in global_symbol_searcher::add_matching_msymbols refers > to find_pc_symtab, which does not exist anymore. The code calls > find_compunit_symtab_for_pc. > > - The comment of global_symbol_searcher calls it a structure, but it > is a class. > > - RESULTS_SET -> RESULT_SET > > - MAX_SEARCH_RESULTS -> M_MAX_SEARCH_RESULTS Approved-By: Andrew Burgess Thanks, Andrew