From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19212 invoked by alias); 9 Feb 2007 19:39:59 -0000 Received: (qmail 19203 invoked by uid 22791); 9 Feb 2007 19:39:58 -0000 X-Spam-Check-By: sourceware.org Received: from tamu-relay.tamu.edu (HELO tr-5-int.cis.tamu.edu) (165.91.22.121) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Feb 2007 19:39:51 +0000 Received: from localhost (localhost.tamu.edu [127.0.0.1]) by tr-5-int.cis.tamu.edu (Postfix) with ESMTP id D8402C946E; Fri, 9 Feb 2007 13:39:49 -0600 (CST) Received: from tr-5-int.cis.tamu.edu ([127.0.0.1]) by localhost (smtp-relay.tamu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02853-02; Fri, 9 Feb 2007 13:39:49 -0600 (CST) Received: from postal.cs.tamu.edu (postal.cs.tamu.edu [128.194.138.100]) by tr-5-int.cis.tamu.edu (Postfix) with ESMTP id 01B40C90A5; Fri, 9 Feb 2007 13:39:48 -0600 (CST) Received: from soliton.cs.tamu.edu (soliton.cs.tamu.edu [128.194.146.33]) by postal.cs.tamu.edu (Postfix) with ESMTP id BD23946DE01; Fri, 9 Feb 2007 13:39:48 -0600 (CST) Received: by soliton.cs.tamu.edu (Postfix, from userid 1000) id 6AB5E1AA37; Fri, 9 Feb 2007 13:39:51 -0600 (CST) To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Subject: Re: PATCH to gdb/linux-nat.c References: <87odo3ofzd.fsf@soliton.cs.tamu.edu> <20070209134923.GA6631@nevyn.them.org> <87tzxve17m.fsf@soliton.cs.tamu.edu> <20070209192353.GA30049@nevyn.them.org> From: Gabriel Dos Reis In-Reply-To: <20070209192353.GA30049@nevyn.them.org> Date: Fri, 09 Feb 2007 19:39:00 -0000 Message-ID: <87irebm86x.fsf@soliton.cs.tamu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00138.txt.bz2 Daniel Jacobowitz writes: | On Fri, Feb 09, 2007 at 10:37:49AM -0600, Gabriel Dos Reis wrote: | > Daniel Jacobowitz writes: | > | > | On Fri, Feb 09, 2007 at 03:08:38AM -0600, Gabriel Dos Reis wrote: | > | > 2007-02-09 Gabriel Dos Reis | > | > | > | > * linux-nat.c (linux_nat_find_memory_regions): Don't check the | > | > address of 'filename'; it is always non null. | > | | > | OK, thanks. Do you have write access to GDB? If not, do you want it? | > | > A while ago, when libstdc++-v3 was a standalone project, I had an | > account on sourceware. I think things have changed over the years, so | > yes, I'll welcome a write access t GDB. Thanks! | | OK, now you have write access. Please commit this, and post and commit | a patch adding yourself to the write-after-approval list in | gdb/MAINTAINERS. Thanks for the patch! Great; that was quick! Many thanks. One more favor: Would you mind looking at my other patch? The GCC PR I filled was demonstrated to be a duplicate and nothing happened since the first PR was filled; I believe GDB+GCC-4.2.0 is affected too. I think the patch I sent works around the problem within GDB and "improves" the const-correctness of the two functions involved. Thanks, -- Gaby