From: Jim Meyering <jim@meyering.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Corinna Vinschen <vinschen@redhat.com>
Subject: Re: rawhide's gdb segfaults, w/patch
Date: Sun, 18 Jan 2009 19:04:00 -0000 [thread overview]
Message-ID: <87iqocqvub.fsf@meyering.net> (raw)
In-Reply-To: <20090109214512.GA5851@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Fri, 9 Jan 2009 22:45:12 +0100")
Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> thanks but your patch needed a second part. It is a regression from:
> http://sourceware.org/ml/gdb-cvs/2008-04/msg00136.html
>
> On Sun, 28 Dec 2008 18:30:14 +0100, Jim Meyering wrote:
>> Here's an untested and quite possibly-wrong patch.
>> I.e., if the warning should be given even when "thisfun" is NULL,
>> it would have to be different.
>
> I find it right as gdbarch_return_value_ftype even has a comment:
> FUNCTYPE may be NULL in which case the return convention is computed based
> only on VALTYPE.
>
> This new argument and functype|func_type is only used in sh-tdep.c
> http://sourceware.org/ml/gdb-patches/2008-04/msg00277.html
> and even there it can be safely NULL.
>
> This new argument and functype|func_type was added by
> http://sourceware.org/ml/gdb-patches/2008-04/msg00276.html
>
>
> I find just questionable whether the new testcase should be in
> gdb.base/nodebug.exp or gdb.base/return*.exp but may be any way is OK.
Thanks again.
This bug still affects rawhide's gdb-6.8.50.20081214-1.fc11.x86_64.
Is there anything I can do to help get the patch in?
next prev parent reply other threads:[~2009-01-18 19:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-28 19:37 Jim Meyering
2009-01-09 21:45 ` Jan Kratochvil
2009-01-10 9:52 ` Jim Meyering
2009-01-18 19:04 ` Jim Meyering [this message]
2009-01-18 19:23 ` Jan Kratochvil
2009-02-02 18:44 ` Tom Tromey
2009-02-11 19:46 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqocqvub.fsf@meyering.net \
--to=jim@meyering.net \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox