From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3880 invoked by alias); 24 Apr 2012 17:58:57 -0000 Received: (qmail 3871 invoked by uid 22791); 24 Apr 2012 17:58:56 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 17:58:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OHwh7R012209 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Apr 2012 13:58:43 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3OHwfw5031328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 24 Apr 2012 13:58:42 -0400 From: Tom Tromey To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Refactor observer.sh to cleanup unused vars References: Date: Tue, 24 Apr 2012 17:59:00 -0000 In-Reply-To: (Sergio Durigan Junior's message of "Tue, 24 Apr 2012 14:53:06 -0300") Message-ID: <87ipgpdnam.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00815.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> + if test ! -z ${notify_args}; then I think there should be double quotes here, like "${notify_args}". Ok with that change. Tom