From: Tom Tromey <tromey@redhat.com>
To: dje@google.com
Cc: Yao Qi <yao@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/4] new gdb_queue.h in common/.
Date: Tue, 11 Sep 2012 16:50:00 -0000 [thread overview]
Message-ID: <87ipbka4i4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20550.27760.260327.470212@ruffy2.mtv.corp.google.com> (dje@google.com's message of "Tue, 4 Sep 2012 14:02:40 -0700")
>>>>> "Doug" == Douglas Evans <dje@google.com> writes:
Doug> Yeah, OTOH this is how "extended" versions of API functions come into being.
Doug> They're a wart in the API so I like to avoid them.
Doug> E.g. consider htab_create_alloc vs htab_create_alloc_ex in the hashtab API.
Doug> Some might not think this is a wart, alas I do, so this is one situation
Doug> where I don't like to lazily add stuff (when I'm aware of it at
Doug> the time ... :-)).
Doug> OTOOH, since we're lazily adding the object version of the API anyway,
Doug> I don't feel too strongly about it here.
I think the difference is that if the code is all in gdb, then a change
can also easily update all uses. This isn't true for hashtab.
Tom
next prev parent reply other threads:[~2012-09-11 16:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 2:26 [RCF 0/4] A general notification in GDB RSP Yao Qi
2012-08-24 2:26 ` [PATCH 3/4] de-couple %Stop from notification: gdbserver Yao Qi
2012-08-24 2:26 ` [PATCH 2/4] de-couple %Stop from notification: gdb Yao Qi
2012-08-24 16:52 ` Yao Qi
2012-08-24 19:00 ` dje
2012-08-30 6:40 ` Yao Qi
2012-08-24 2:26 ` [PATCH 1/4] new gdb_queue.h in common/ Yao Qi
2012-08-24 18:44 ` dje
2012-08-24 18:49 ` Doug Evans
2012-08-29 9:42 ` Yao Qi
2012-09-04 21:03 ` dje
2012-09-07 2:47 ` Yao Qi
2012-09-10 20:47 ` dje
2012-09-12 14:24 ` Yao Qi
2012-09-13 15:55 ` dje
2012-09-14 2:38 ` Yao Qi
2012-09-11 16:50 ` Tom Tromey [this message]
2012-08-24 2:26 ` [PATCH 4/4] new notification "TEST" Yao Qi
2012-08-24 17:53 ` [RCF 0/4] A general notification in GDB RSP Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipbka4i4.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox