Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFC: fix latent bug in syms_from_objfile_1
Date: Wed, 20 Mar 2013 18:23:00 -0000	[thread overview]
Message-ID: <87ip4m7wxy.fsf@fleche.redhat.com> (raw)

I recently upgraded to Fedora 18.  I randomly see this from gdb:

    warning: no loadable sections found in added symbol-file system-supplied DSO at 0x7ffff7ffd000

I tracked this warning down to a buglet in syms_from_objfile_1, which
references addrs->other[0] without first checking addrs->num_sections.

This patch fixes the problem.

Built and regtested on x86-64 Fedora 18.
This actually improves the test results for me by removing a number of
bogus FAILs caused when the warning is emitted.

Any comments?

Tom

2013-03-20  Tom Tromey  <tromey@redhat.com>

	* symfile.c (syms_from_objfile_1): Check num_sections before
	calling addr_info_make_relative.

Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.367
diff -u -r1.367 symfile.c
--- symfile.c	14 Mar 2013 20:26:19 -0000	1.367
+++ symfile.c	20 Mar 2013 18:19:42 -0000
@@ -997,7 +997,7 @@
 
      We no longer warn if the lowest section is not a text segment (as
      happens for the PA64 port.  */
-  if (addrs && addrs->other[0].name)
+  if (addrs && addrs->num_sections > 0 && addrs->other[0].name)
     addr_info_make_relative (addrs, objfile->obfd);
 
   /* Initialize symbol reading routines for this objfile, allow complaints to


             reply	other threads:[~2013-03-20 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 18:23 Tom Tromey [this message]
2013-03-20 19:06 ` Jan Kratochvil
2013-03-20 19:53   ` Tom Tromey
2013-03-21 14:41     ` Jan Kratochvil
2013-03-21 15:36       ` Tom Tromey
2013-03-21 16:08         ` Jan Kratochvil
2013-03-21 17:39           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip4m7wxy.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox