[PATCH 21/40] fix py-value.c

Tom Tromey
2013-05-09T18:51:48Z

Some code in py-value.c could exit a loop without running some
cleanups made in the loop.

* python/py-value.c (valpy_binop): Call do_cleanups before
exiting loop.
---
gdb/python/py-value.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/python/py-value.c b/gdb/python/py-value.c
index 2cbb0cb..da74982 100644
--- a/gdb/python/py-value.c
+++ b/gdb/python/py-value.c
@@ -776,11 +776,17 @@ valpy_binop (enum valpy_opcode opcode, PyObject *self, PyObject *other)
a gdb.Value object and need to convert it from python as well. */
arg1 = convert_value_from_python (self);
if (arg1 == NULL)
- break;
+ {
+ do_cleanups (cleanup);
+ break;
+ }

arg2 = convert_value_from_python (other);
if (arg2 == NULL)
- break;
+ {
+ do_cleanups (cleanup);
+ break;
+ }

switch (opcode)
{
--
1.8.1.4