From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28193 invoked by alias); 10 Oct 2013 02:29:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28179 invoked by uid 89); 10 Oct 2013 02:29:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 02:29:57 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9A2Ttmo008230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Oct 2013 22:29:55 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9A2TsiO023308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 9 Oct 2013 22:29:55 -0400 From: Tom Tromey To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] fix PR symtab/15597 References: <1375983426-19308-1-git-send-email-tromey@redhat.com> <87pprfft9c.fsf@fleche.redhat.com> <21077.61952.984944.635448@ruffy.mtv.corp.google.com> Date: Thu, 10 Oct 2013 02:29:00 -0000 In-Reply-To: <21077.61952.984944.635448@ruffy.mtv.corp.google.com> (Doug Evans's message of "Wed, 9 Oct 2013 17:17:04 -0700") Message-ID: <87iox5ame5.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00330.txt.bz2 Doug> So code was moved to a different file and edited in one step Doug> (instead of moving it, and then editing it in a separate pass)? In this case I thought it couldn't reasonably be moved verbatim, since, IIRC, prior to my changes it required ELF bits from BFD, not allowed in generic code. Doug> [not that I mind per se, but I thought doing things that way Doug> was more than just "nice to have"] In your case the two changes had nothing to do with one another. I think that is a reasonable standard. If you disagree, I'm sure we can all agree on some other standard. Tom