From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30363 invoked by alias); 17 Oct 2013 18:42:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30350 invoked by uid 89); 17 Oct 2013 18:42:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2013 18:42:46 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9HIgjcd005505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Oct 2013 14:42:45 -0400 Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9HIgiIV018819 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 17 Oct 2013 14:42:44 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 05/13] fix up gdb.xml References: <1377290210-483-1-git-send-email-tromey@redhat.com> <1377290210-483-6-git-send-email-tromey@redhat.com> <521C97AE.4040707@redhat.com> Date: Thu, 17 Oct 2013 18:42:00 -0000 In-Reply-To: <521C97AE.4040707@redhat.com> (Pedro Alves's message of "Tue, 27 Aug 2013 13:12:30 +0100") Message-ID: <87iowvvivw.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00533.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Should be: Pedro> set msg "set tdesc filename tdesc-arch.xml ($which architecture)" Thanks, fixed here. >> set cmd_regex [string_to_regexp $cmd] >> gdb_test_multiple $cmd $msg { >> -re "^$cmd_regex\r\n$gdb_prompt $" { >> @@ -86,31 +89,32 @@ proc set_arch { arch which } { >> "The target architecture is set automatically \\(currently $arch\\)" \ >> "$cmd ($which architecture)" >> >> - file delete "${subdir}/tdesc-arch.xml" >> - remote_file host delete "tdesc-arch.xml" >> + remote_file host delete $filename Pedro> I noticed this seems to leave the build machine's copy Pedro> behind. Was that on purpose? Yeah. It seemed simpler to just leave it around. I think it's generally a mistake to delete intermediate files on the build machine -- it makes debugging the test suite harder, and with the parallel mode it is generally trivial to clean up anyway. >> # Similarly, we need to copy files under test into the objdir. >> -proc load_description { file errmsg } { >> +proc load_description { file errmsg {should_cd 1} } { Pedro> Could you add a comment on the should_cd parameter please? Pedro> It's not obvious to me why a test should cd, while the other Pedro> shouldn't. Done. Tom