From: jose.marchesi@oracle.com (Jose E. Marchesi)
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: sigall.exp: handle SIGLOST/SIGPWR conflict in sparc64 targets
Date: Tue, 03 Dec 2013 11:58:00 -0000 [thread overview]
Message-ID: <87iov6w3g9.fsf@oracle.com> (raw)
In-Reply-To: <877gd4t72x.fsf@oracle.com> (Jose E. Marchesi's message of "Wed, 23 Oct 2013 16:06:30 +0200")
ping
Hi.
In sparc64 SIGLOST and SIGPWR have the same signal number. The
following patch fixes gdb.base/sigall.exp accordingly.
Tested in sparc64-unknown-linux-gnu.
2013-10-23 Jose E. Marchesi <jose.marchesi@oracle.com>
* gdb.base/sigall.exp (test_one_sig): gdb identifies SIGLOST as a
SIGPWR in sparc64.
* gdb.base/sigall.c (main): In some targets SIGLOST and SIGPWR
have the same signal number. Handle this situation.
diff --git a/gdb/testsuite/gdb.base/sigall.c b/gdb/testsuite/gdb.base/sigall.c
index 110029d..68f3ecb 100644
--- a/gdb/testsuite/gdb.base/sigall.c
+++ b/gdb/testsuite/gdb.base/sigall.c
@@ -1083,7 +1083,7 @@ return 0;
int
gen_PWR ()
{
-#ifdef SIGPWR
+#if defined(SIGPWR) && (!defined (SIGLOST) || SIGPWR != SIGLOST)
kill (getpid (), SIGPWR);
#else
handle_PWR (0);
@@ -1662,7 +1662,7 @@ main ()
#ifdef SIGUSR2
signal (SIGUSR2, handle_USR2);
#endif
-#ifdef SIGPWR
+#if defined(SIGPWR) && (!defined (SIGLOST) || SIGPWR != SIGLOST)
signal (SIGPWR, handle_PWR);
#endif
#if defined (SIGPOLL) && (!defined (SIGIO) || SIGPOLL != SIGIO)
diff --git a/gdb/testsuite/gdb.base/sigall.exp b/gdb/testsuite/gdb.base/sigall.exp
index b1b8597..4bfb199 100644
--- a/gdb/testsuite/gdb.base/sigall.exp
+++ b/gdb/testsuite/gdb.base/sigall.exp
@@ -39,12 +39,20 @@ proc test_one_sig {nextsig} {
set need_another_continue 1
set missed_handler 0
if $this_sig_supported then {
+ set esig $thissig
+
if { $thissig == "IO" } {
setup_xfail "i*86-pc-linuxoldld-gnu" "i*86-pc-linuxaout-gnu"
}
+ # In SPARC64 systems SIGLOST==SIGPWR and gdb identifies the raised
+ # signal as PWR.
+ if { $thissig == "LOST" && [ istarget "sparc64-*-linux*" ] } then {
+ set esig "PWR"
+ }
+
gdb_test "continue" \
- "Continuing.*Program received signal SIG$thissig.*" \
- "get signal $thissig"
+ "Continuing.*Program received signal SIG$esig.*" \
+ "get signal $esig"
}
if [ istarget "alpha-dec-osf3*" ] then {
# OSF/1-3.x is unable to continue with a job control stop signal.
next prev parent reply other threads:[~2013-12-03 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 14:04 Jose E. Marchesi
2013-12-03 11:58 ` Jose E. Marchesi [this message]
2013-12-03 12:07 ` Mark Kettenis
2013-12-03 12:53 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iov6w3g9.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox