From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29328 invoked by alias); 21 Feb 2014 13:05:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29315 invoked by uid 89); 21 Feb 2014 13:05:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_SEMBACKSCATTER,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp14.uk.ibm.com Received: from e06smtp14.uk.ibm.com (HELO e06smtp14.uk.ibm.com) (195.75.94.110) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 21 Feb 2014 13:05:37 +0000 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 21 Feb 2014 13:05:34 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 21 Feb 2014 13:05:32 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 60CB317D8062 for ; Fri, 21 Feb 2014 13:06:03 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s1LD5K0p34603118 for ; Fri, 21 Feb 2014 13:05:20 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s1LD5VVV015901 for ; Fri, 21 Feb 2014 06:05:32 -0700 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-219.boeblingen.de.ibm.com [9.152.212.219]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s1LD5UIo015870; Fri, 21 Feb 2014 06:05:31 -0700 From: Andreas Arnez To: gdb-patches@sourceware.org Cc: Ulrich Weigand , Andreas Krebbel , Yao Qi Subject: [PATCH] Fix length arg in call to breakpoint_xfer_memory Date: Fri, 21 Feb 2014 13:05:00 -0000 Message-ID: <87ios8fwf9.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14022113-1948-0000-0000-000007E46872 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00690.txt.bz2 The patch "return target_xfer_status in to_xfer_partial" caused a regression in various s390(x) test cases, because memory_xfer_partial filled only the first byte of the read buffer from a breakpoint shadow: https://sourceware.org/ml/gdb-patches/2014-01/msg01071.html This patch fixes the regression. ChangeLog/ * target.c (memory_xfer_partial): Fix length arg in call to breakpoint_xfer_memory. --- gdb/target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/target.c b/gdb/target.c index 4adc094..0f3bd30 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -1348,7 +1348,7 @@ memory_xfer_partial (struct target_ops *ops, enum target_object object, xfered_len); if (res == TARGET_XFER_OK && !show_memory_breakpoints) - breakpoint_xfer_memory (readbuf, NULL, NULL, memaddr, res); + breakpoint_xfer_memory (readbuf, NULL, NULL, memaddr, *xfered_len); } else { -- 1.8.3.1