From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6623 invoked by alias); 24 Jun 2014 13:44:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6613 invoked by uid 89); 24 Jun 2014 13:44:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 Jun 2014 13:44:38 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5ODiaYo014344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2014 09:44:36 -0400 Received: from barimba (ovpn-113-138.phx2.redhat.com [10.3.113.138]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5ODiY6S026486 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 24 Jun 2014 09:44:35 -0400 From: Tom Tromey To: Markus Metzger Cc: palves@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/3] make_corefile_notes: have caller free returned memory References: <1403599872-25299-1-git-send-email-markus.t.metzger@intel.com> Date: Tue, 24 Jun 2014 13:44:00 -0000 In-Reply-To: <1403599872-25299-1-git-send-email-markus.t.metzger@intel.com> (Markus Metzger's message of "Tue, 24 Jun 2014 10:51:10 +0200") Message-ID: <87ionq4e2l.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-06/txt/msg00854.txt.bz2 >>>>> "Markus" == Markus Metzger writes: Markus> if (note_data == NULL || note_size == 0) Markus> error (_("Target does not support core file generation.")); Markus> + cleanup = make_cleanup (xfree, note_data); I wonder if it is possible for note_data!=NULL but note_size==0. If it is possible, then the cleanup ought to be moved earlier. (FWIW it's ok to have an xfree cleanup with a NULL argument.) Or if it is not possible, then I suppose the code just above is in error... not your problem but if you happen to know, I would like to fix it up. thanks, Tom