Re: [PATCH 2/9] Move `compute_probe_arg' and `compile_probe_arg' to probe.c

Jose E. Marchesi
2014-10-10T16:38:44Z

> This patch moves the `compute_probe_arg' and `compile_probe_arg' functions
> from stap-probe.c to probe.c. The rationale is that it is reasonable to
> assume that all backends will provide the `$_probe_argN' convenience
> variables, and that the user must be placed on the PC of the probe when
> requesting that information. The value and type of the argument can still be
> determined by the probe backend via the `pops->evaluate_probe_argument' and
> `pops->compile_to_ax' handlers.
>
> Note that a test in gdb.base/stap-probe.exp had to be adjusted because the "No
> SystemTap probe at PC" messages are now "No probe at PC".

Hi Jose,

Thanks for this patch.

Just a nit on the ChangeLog entry.

Fixed in the patch.