From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7657 invoked by alias); 14 Nov 2014 18:52:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7645 invoked by uid 89); 14 Nov 2014 18:52:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 14 Nov 2014 18:52:50 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1XpLtR-0003mg-7L; Fri, 14 Nov 2014 19:46:49 +0100 From: Gabriel Krisman Bertazi To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] Update documentation on catching a group of related syscalls. References: <1414956944-8856-1-git-send-email-gabriel@krisman.be> <1414956944-8856-5-git-send-email-gabriel@krisman.be> <83vbmxwfnk.fsf@gnu.org> <87ppctkwcz.fsf@krisman.be> <83wq71krkh.fsf@gnu.org> Date: Fri, 14 Nov 2014 18:52:00 -0000 In-Reply-To: <83wq71krkh.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Nov 2014 05:47:58 +0200") Message-ID: <87ioih398l.fsf@krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00336.txt.bz2 --=-=-= Content-Type: text/plain Content-length: 488 Eli Zaretskii writes: > Yes, saying that TAB-completion (including M-TAB) can be used to see > the list of groups is fine with me. Here goes a new version of this part. What about the other parts, are they good to go? :) Thanks! gdb/ * breakpoint.c (_initialize_breakpoint): Update catch syscall command documentation. * NEWS: Include section about catching groups of syscalls. gdb/doc/ * gdb.texinfo (Set Catchpoints): Add 'group' argument to catch syscall. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=doc_v3.patch Content-length: 3672 diff --git a/gdb/NEWS b/gdb/NEWS index 649c29e..7e6f8ea 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -60,6 +60,11 @@ SGI Irix-6.x mips-*-irix6* VAX running (4.2 - 4.3 Reno) BSD vax-*-bsd* VAX running Ultrix vax-*-ultrix* +* The "catch syscall" command catches groups of related syscalls. + + The "catch syscall" command now supports catching a group of related + syscalls using the 'group:' or 'g:' prefix. + *** Changes in GDB 7.8 * New command line options diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 8520361..9bd3519 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -16736,11 +16736,11 @@ If REGEX is given, only stop for libraries matching the regular expression."), CATCH_PERMANENT, CATCH_TEMPORARY); add_catch_command ("syscall", _("\ -Catch system calls by their names and/or numbers.\n\ -Arguments say which system calls to catch. If no arguments\n\ -are given, every system call will be caught.\n\ -Arguments, if given, should be one or more system call names\n\ -(if your system supports that), or system call numbers."), +Catch system calls by their names, groups and/or numbers. Arguments\n\ +say which system calls to catch. If no arguments are given, every\n\ +system call will be caught. Arguments, if given, should be one or\n\ +more system call names (if your system supports that), system call\n\ +groups or system call numbers."), catch_syscall_command_1, catch_syscall_completer, CATCH_PERMANENT, diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 15c2908..83d8d64 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -4254,7 +4254,7 @@ A call to @code{exec}. This is currently only available for HP-UX and @sc{gnu}/Linux. @item syscall -@itemx syscall @r{[}@var{name} @r{|} @var{number}@r{]} @dots{} +@itemx syscall @r{[}@var{name} @r{|} @var{number} @r{|} @r{group:}@var{groupname} @r{|} @r{g:}@var{groupname}@r{]} @dots{} @kindex catch syscall @cindex break on a system call. A call to or return from a system call, a.k.a.@: @dfn{syscall}. A @@ -4289,6 +4289,15 @@ may be useful if @value{GDBN}'s database does not have the complete list of syscalls on your system (e.g., because @value{GDBN} lags behind the OS upgrades). +You may specify a group of related syscalls to be caught at once using +the @code{group:} syntax (@code{g:} is a shorter equivalent.). For +instance, on some platforms @value{GDBN} allows you to catch all +network related syscalls, by passing the argument @code{group:network} +to @code{catch syscall}. Note that not all syscall groups are +available in every system. You can use the command completion +facilities (@pxref{Completion,, command completion}) to list the +syscall groups available on your environment. + The example below illustrates how this command works if you don't provide arguments to it: @@ -4345,6 +4354,23 @@ Program exited normally. (@value{GDBP}) @end smallexample +Here is an example of catching a syscall group: + +@smallexample +(@value{GDBP}) catch syscall group:process +Catchpoint 1 (syscalls 'exit' [1] 'fork' [2] 'waitpid' [7] +'execve' [11] 'wait4' [114] 'clone' [120] 'vfork' [190] +'exit_group' [252] 'waitid' [284] 'unshare' [310]) +(@value{GDBP}) r +Starting program: /tmp/catch-syscall + +Catchpoint 1 (call to syscall fork), 0x00007ffff7df4e27 in open64 () + from /lib64/ld-linux-x86-64.so.2 + +(@value{GDBP}) c +Continuing. +@end smallexample + However, there can be situations when there is no corresponding name in XML file for that syscall number. In this case, @value{GDBN} prints a warning message saying that it was not able to find the syscall name, --=-=-= Content-Type: text/plain Content-length: 29 -- Gabriel Krisman Bertazi --=-=-=--