From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1507 invoked by alias); 8 Feb 2017 23:05:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1483 invoked by uid 89); 8 Feb 2017 23:05:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=lands, H*Ad:U*tom X-HELO: gproxy3-pub.mail.unifiedlayer.com Received: from gproxy3-pub.mail.unifiedlayer.com (HELO gproxy3-pub.mail.unifiedlayer.com) (69.89.30.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 08 Feb 2017 23:04:58 +0000 Received: (qmail 22095 invoked by uid 0); 8 Feb 2017 23:04:56 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy3.mail.unifiedlayer.com with SMTP; 8 Feb 2017 23:04:56 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id iP4t1u00H2f2jeq01P4wBH; Wed, 08 Feb 2017 16:04:56 -0700 X-Authority-Analysis: v=2.1 cv=Pets2ERd c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=20KFwNOVAAAA:8 a=0w4YycSfh-zbCUylumYA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 75-171-235-161.hlrn.qwest.net ([75.171.235.161]:49936 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cbbIC-0005Z1-Sv; Wed, 08 Feb 2017 16:04:52 -0700 From: Tom Tromey To: Pedro Alves Cc: Trevor Saunders , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/5] Remove some ui_out-related cleanups from Python References: <20170115134253.24018-1-tom@tromey.com> <20170115134253.24018-2-tom@tromey.com> <20170116113021.sar3yh5ivykpqmbw@ball> Date: Wed, 08 Feb 2017 23:05:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 8 Feb 2017 17:28:11 +0000") Message-ID: <87inok708e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cbbIC-0005Z1-Sv X-Source-Sender: 75-171-235-161.hlrn.qwest.net (bapiya) [75.171.235.161]:49936 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-02/txt/msg00208.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> One difficulty with putting such a thing at the top level is that Pedro> gdb relies on gnulib headers (that exist under gdb/) while Pedro> other toolchain components don't, yet, at least. gnulib should just be at top-level, but I realize that's a pain. Pedro> It probably does make sense to start with something simpler and Pedro> upgrade when/if we find a need. OTOH, looks like the current patch Pedro> doesn't have accessors for the wrapped value, so it seems like we'll Pedro> at least need to be extend it in that direction in no time. I had forgotten about this code. I don't mind using it instead. Pedro> Patch LGTM with Trevor's and Simon's nits addressed. I have that done locally, but I've just been waiting until your series lands, so I can rebase. And then maybe the option stuff wouldn't be needed anyway? I don't remember the details from your branch, I was just waiting for the big rebase to find out. Tom