From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94766 invoked by alias); 10 Apr 2017 13:57:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94734 invoked by uid 89); 10 Apr 2017 13:57:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:42364, HTo:D*polymtl.ca, H*RU:cmgw2, Hx-spam-relays-external:cmgw2 X-HELO: gproxy2-pub.mail.unifiedlayer.com Received: from gproxy2-pub.mail.unifiedlayer.com (HELO gproxy2-pub.mail.unifiedlayer.com) (69.89.18.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 10 Apr 2017 13:57:20 +0000 Received: (qmail 25502 invoked by uid 0); 10 Apr 2017 13:57:20 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy2.mail.unifiedlayer.com with SMTP; 10 Apr 2017 13:57:20 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id 6dxH1v0022f2jeq01dxLYb; Mon, 10 Apr 2017 07:57:20 -0600 X-Authority-Analysis: v=2.2 cv=LIwWeNe9 c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=LuzPxN3xsHNnT0JY2C8A:9 Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:42364 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cxZoi-0001dK-Rn; Mon, 10 Apr 2017 07:57:16 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 08/14] Remove some cleanups from gnu-v3-abi.c References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-9-tom@tromey.com> <9067796064c9df3220f55405282dc9f8@polymtl.ca> Date: Mon, 10 Apr 2017 13:57:00 -0000 In-Reply-To: <9067796064c9df3220f55405282dc9f8@polymtl.ca> (Simon Marchi's message of "Mon, 10 Apr 2017 00:08:24 -0400") Message-ID: <87inmc2wnd.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cxZoi-0001dK-Rn X-Source-Sender: 75-166-65-226.hlrn.qwest.net (pokyo) [75.166.65.226]:42364 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-04/txt/msg00242.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Pass the vector by reference? Otherwise, LGTM. I tend to avoid passing by non-const reference, because passing a pointer makes it more clear in the caller that mutation will be happening. Tom