From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123649 invoked by alias); 21 Jun 2017 20:31:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122981 invoked by uid 89); 21 Jun 2017 20:31:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 20:31:40 +0000 From: Sergio Durigan Junior To: Simon Marchi Cc: Subject: Re: [PATCH 2/4] x86-dregs: Print debug registers one per line References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> <1498076108-29914-3-git-send-email-simon.marchi@ericsson.com> X-URL: https://sergiodj.net Date: Wed, 21 Jun 2017 20:31:00 -0000 In-Reply-To: <1498076108-29914-3-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 21 Jun 2017 22:15:06 +0200") Message-ID: <87injpccb9.fsf@sergiodj.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-06/txt/msg00608.txt.bz2 On Wednesday, June 21 2017, Simon Marchi wrote: > This get around this warning given by clang... > > /home/emaisin/src/binutils-gdb/gdb/nat/x86-dregs.c:209:7: error: variable 'i' is incremented both in the loop header and in the loop body [-Werror,-Wfor-loop-analysis] > i++; > ^ > /home/emaisin/src/binutils-gdb/gdb/nat/x86-dregs.c:199:32: note: incremented here > ALL_DEBUG_ADDRESS_REGISTERS (i) > ^ > > ... I decided in the end to simply print the debug registers one per > line. I don't think it particularly helps readability to have them two > per line anyway. Agreed, one per line sounds better to me. > > gdb/ChangeLog: > > * nat/x86-dregs.c (x86_show_dr): Print registers one per line. > --- > gdb/nat/x86-dregs.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/gdb/nat/x86-dregs.c b/gdb/nat/x86-dregs.c > index 8c8adfa..58b1179 100644 > --- a/gdb/nat/x86-dregs.c > +++ b/gdb/nat/x86-dregs.c > @@ -193,20 +193,16 @@ x86_show_dr (struct x86_debug_reg_state *state, > here. */ > : "??unknown??")))); > debug_printf (":\n"); > - debug_printf ("\tCONTROL (DR7): %s STATUS (DR6): %s\n", > - phex (state->dr_control_mirror, 8), > - phex (state->dr_status_mirror, 8)); > + > + debug_printf ("\tCONTROL (DR7): 0x%s\n",phex (state->dr_control_mirror, 8)); ^^^ Space after comma? > + debug_printf ("\tSTATUS (DR6): 0x%s\n", phex (state->dr_status_mirror, 8)); > + > ALL_DEBUG_ADDRESS_REGISTERS (i) > { > - debug_printf ("\ > -\tDR%d: addr=0x%s, ref.count=%d DR%d: addr=0x%s, ref.count=%d\n", > + debug_printf ("\tDR%d: addr=0x%s, ref.count=%d\n", > i, phex (state->dr_mirror[i], > x86_get_debug_register_length ()), > - state->dr_ref_count[i], > - i + 1, phex (state->dr_mirror[i + 1], > - x86_get_debug_register_length ()), > - state->dr_ref_count[i + 1]); > - i++; > + state->dr_ref_count[i]); > } > } > > -- > 2.7.4 LGTM. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/