Re: [PATCH v2] Use "switch_to_thread" more thoroughly on gdbserver

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Tuesday, September 26 2017, Pedro Alves wrote:

> On 09/26/2017 05:22 AM, Sergio Durigan Junior wrote:
>
>> gdb/gdbserver/ChangeLog:
>> yyyy-mm-dd  Sergio Durigan Junior  <sergiodj@redhat.com>
>> 
>> 	* gdbthread.h: Include "common-gdbthread.h".
>> 	* inferiors.c (switch_to_thread): Use "gdb_assert" instead of
>> 	"if" when validating the ptid.
>> 	* remote-utils.c: Include "gdbthread.h".
>> 	(prepare_resume_reply): Use "switch_to_thread".
>> 	* target.c (done_accessing_memory): Likewise.
>
> OK
>
>>  void
>>  switch_to_thread (ptid_t ptid)
>>  {
>> -  if (!ptid_equal (ptid, minus_one_ptid))
>> -    current_thread = find_thread_ptid (ptid);
>> +  gdb_assert (!ptid_equal (ptid, minus_one_ptid));
>
> Note you can write:
>
>   gdb_assert (ptid != minus_one_ptid);
>
> nowadays.

That's right; pushed with this small nit fixed.

75352e283fb2b265d14c750859156943f6eb2693

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/