From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32153 invoked by alias); 21 May 2018 15:52:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32137 invoked by uid 89); 21 May 2018 15:52:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.125) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 May 2018 15:52:38 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 6B42B31E55 for ; Mon, 21 May 2018 10:52:37 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Kn6zfW0GZBcCXKn6zfQrga; Mon, 21 May 2018 10:52:37 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:49352 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fKn6z-001ZQw-5z; Mon, 21 May 2018 10:52:37 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Remove a cleanup from trace_dump_actions References: <20180519151757.18031-1-tom@tromey.com> <58b3d43f-6267-4d24-1e9c-ed0ffc32fe24@simark.ca> Date: Mon, 21 May 2018 16:04:00 -0000 In-Reply-To: <58b3d43f-6267-4d24-1e9c-ed0ffc32fe24@simark.ca> (Simon Marchi's message of "Sun, 20 May 2018 19:44:33 -0400") Message-ID: <87in7h2egr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fKn6z-001ZQw-5z X-Source-Sender: 174-29-44-154.hlrn.qwest.net (bapiya) [174.29.44.154]:49352 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00485.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-05-19 11:17 AM, Tom Tromey wrote: >> This changes trace_dump_actions to use std::string, removing a >> cleanup. Simon> LGTM, but I would suggest finding another name for cmd, to avoid Simon> shadowing the other cmd variable. I renamed it to "exp", since it is an expression, not a command. Tom