From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74251 invoked by alias); 8 Jul 2018 16:26:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74238 invoked by uid 89); 8 Jul 2018 16:26:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:26:51 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 1FF538FC98 for ; Sun, 8 Jul 2018 11:26:50 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cCWQfOAALRPojcCWQfxyOm; Sun, 08 Jul 2018 11:26:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/WUuuBdVgBVSaA+If3zcllMLfYOsNtVpFcDsHFp+IcY=; b=IExsfeQRXNhVIxnqafNyPf0BF8 LeIOxAKMVQtl/C8SJcrZa8O1rcAhqVIFdQzwsf6d7UqkTb4Kh5QLqSaHxMQDseroxwMugJqNnSqjk tS+n3sZ6yYgj1GmmWl3C/Sm+Q; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:42982 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fcCWP-001Rgc-Rw; Sun, 08 Jul 2018 11:26:49 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 06/42] Move have_line_numbers to buildsym_compunit References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-7-tom@tromey.com> <62ee17d0-af6d-5fde-855f-52b9a8d87189@redhat.com> Date: Sun, 08 Jul 2018 16:26:00 -0000 In-Reply-To: <62ee17d0-af6d-5fde-855f-52b9a8d87189@redhat.com> (Keith Seitz's message of "Thu, 5 Jul 2018 12:01:25 -0700") Message-ID: <87in5p66d3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00185.txt.bz2 >>>>> "Keith" == Keith Seitz writes: >> - && have_line_numbers == 0 >> + && buildsym_compunit->m_have_line_numbers == 0 Keith> Since m_have_line_numbers was declared bool, I prefer (and I Keith> think most do?) that the comparison use `false' instead. I changed it to just !have_line_numbers. Tom