From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111850 invoked by alias); 14 Jul 2018 12:40:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111834 invoked by uid 89); 14 Jul 2018 12:40:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bubble X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.144.98) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jul 2018 12:40:32 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway32.websitewelcome.com (Postfix) with ESMTP id EBDFD1ADD689 for ; Sat, 14 Jul 2018 07:40:30 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eJqZfZaDibXuJeJqefi2ZZ; Sat, 14 Jul 2018 07:40:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=942EJpiovNJbN5r8+T5vn27trlY5YabBNcQLnj6kXo4=; b=VSuWFOpLS9IoBTTfr2L8BXh7iB TFMjvflKkoC7LWANRifkqbsgWq/akYInsVe/CgVJ+xgn1gbwqjAw4VOOkDD7vuAJ6iEiEOdemZON1 3HlaJFwqoc+VL6RNBbGACrCCu; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:35136 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1feJqR-004Eu8-Uk; Sat, 14 Jul 2018 07:40:16 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 01/13] Simple unused variable removals References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-2-tom@tromey.com> <87b519fc-318a-84aa-7ced-aea354f059fb@simark.ca> Date: Sat, 14 Jul 2018 12:40:00 -0000 In-Reply-To: <87b519fc-318a-84aa-7ced-aea354f059fb@simark.ca> (Simon Marchi's message of "Fri, 13 Jul 2018 21:15:47 -0400") Message-ID: <87in5i9ej4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00450.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> - CORE_ADDR size = extract_unsigned_integer (ovly_table + 16*i + 4, Simon> - 4, byte_order); Simon> I wondered this was a bug (should that variable really be used), but I Simon> wouldn't know without some quite extensive research... so all-in-all, LGTM. Yes, this one was on the bubble and I almost put it in its own patch... I can't recall offhand if there were others like this. Tom