From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58712 invoked by alias); 28 Aug 2018 17:52:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58036 invoked by uid 89); 28 Aug 2018 17:52:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 17:52:07 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway32.websitewelcome.com (Postfix) with ESMTP id AD539151334 for ; Tue, 28 Aug 2018 12:52:05 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ui9Wfa7qobXuJui9jfvbVl; Tue, 28 Aug 2018 12:52:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NsLsOSfCswVNDDzlnfVg1JmtoOw20XjXUlJ6Ys33VRo=; b=OnedLe2FzZ1RF9XPW4csq+VROb OWLa+c5VLrcZKp/pxf6PwDME/whUiEpJJmBrWONl5KBIJ4EhbNKTh9TmTEpDdo8GWyO6xtw5A1Bwx Smw2cyOGscCEAv4qhV5xglgV/; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:48052 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fui9W-001zG5-PP; Tue, 28 Aug 2018 12:51:42 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 9/9] C++ compile support References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-10-keiths@redhat.com> <87tvo0sakn.fsf@tromey.com> Date: Tue, 28 Aug 2018 17:52:00 -0000 In-Reply-To: (Keith Seitz's message of "Fri, 17 Aug 2018 11:26:18 -0700") Message-ID: <87in3u5qhd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00702.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> The complete list of changes in this revision: Keith> a) removed "(void)" everywhere Keith> b) removed compile-cplus-support.c and moved functions to Keith> private static members of compile_cplus_instance Keith> c) removed _initialize_XYZ decls Keith> d) moved decl_name to static member of compile_cplus_instance Keith> e) used get instead of release in new_scope Keith> f) KFAIL remaining compile-cplus.exp/compile-cplus-print.exp tests Keith> and fixed a bug uncovered by missing "_no_output" buglet Keith> g) std::string --> const char * to avoid allocation Keith> h) removed type_code_to_string Thank you for updating this. This looks good to me. Tom