Re: [PATCH] gdb: Allow struct fields named double

Tom Tromey
2018-12-16T16:42:22Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> This looks reasonable to me, from the user point of view there is not reason
Simon> why x.double would be different from x.float. With the same logic, we should
Simon> also allow x.int, x.short, etc. But I'm fine with doing it on an as-needed basis.

See also https://sourceware.org/bugzilla/show_bug.cgi?id=13368

Simon> This LGTM, with one thing below you might want to change. I'm far from an expert
Simon> in parsers though, so please give others ~1 week to comment, and push then if you
Simon> don't receive additional feedback.

I think the main possible issue is if this introduces a new parser conflict.
Taking a glance at the uses of "name" in the grammar, though, it seems
safe enough.

Tom