From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85386 invoked by alias); 4 Mar 2019 21:49:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85091 invoked by uid 89); 4 Mar 2019 21:48:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,TRACKER_ID autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Mar 2019 21:48:42 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65D5A3082AEE; Mon, 4 Mar 2019 21:48:30 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EC526085B; Mon, 4 Mar 2019 21:48:30 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches Subject: Re: [PATCH] Use '$enable_unittest' instead of '$development' on gdbserver/configure.srv (for 'aarch64*-*-linux*' case) References: <20190304174924.27024-1-sergiodj@redhat.com> <8281f119488b6db2c0a963412f1b723f@polymtl.ca> Date: Mon, 04 Mar 2019 21:49:00 -0000 In-Reply-To: <8281f119488b6db2c0a963412f1b723f@polymtl.ca> (Simon Marchi's message of "Mon, 04 Mar 2019 13:06:10 -0500") Message-ID: <87imwy5n0y.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00047.txt.bz2 On Monday, March 04 2019, Simon Marchi wrote: > On 2019-03-04 12:49, Sergio Durigan Junior wrote: >> On commit 8ecfd7bd4acd69213c06fac6de9af38299123547 ("Add parameter to >> allow enabling/disabling selftests via configure") it seems that I >> forgot to use the proper '$enable_unittest' variable when checking to >> see whether to add selftest-related objects to 'srv_regobj'. This >> causes a build failure on Aarch64 when 'development=false' (which is >> the case for the 8.3 branch) and 'enable_unittest=true'. >> >> This patch fixes the problem by using '$enable_unittest' instead of >> '$development' when performing the check. As a reminder, it's >> important to notice that '$enable_unittest's default value (i.e., when >> the option '--enable-unit-tests' is not passed to configure) is the >> same as '$development', so this patch doesn't affect the current >> build. >> >> I'd like to install this patch both on master and on the 8.3 branch. >> >> OK? > > Thanks, this LGTM. Thanks, pushed. 45950eb60008c70fb79306012e76a024a8790ca3 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/