From: Tom Tromey <tom@tromey.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/5] Introduce target_ops method thread_info_to_thread_handle
Date: Tue, 05 Mar 2019 21:44:00 -0000 [thread overview]
Message-ID: <87imwxq9ne.fsf@tromey.com> (raw)
In-Reply-To: <20190227193025.3a6750ed@f29-4.lan> (Kevin Buettner's message of "Wed, 27 Feb 2019 19:30:25 -0700")
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
Kevin> +gdb::byte_vector
Kevin> +target_thread_info_to_thread_handle (struct thread_info *tip)
Kevin> +{
Kevin> + return current_top_target ()->thread_info_to_thread_handle (tip);
Kevin> +}
It's the gdb style to stick /* See target.h. */ before the definition.
Kevin> + virtual gdb::byte_vector thread_info_to_thread_handle (struct thread_info *)
Kevin> + TARGET_DEFAULT_RETURN (gdb::byte_vector ());
This should probably have a comment explaining what is meant by the
return value.
Kevin> +/* Given a thread, return the thread handle. */
Kevin> +extern gdb::byte_vector target_thread_info_to_thread_handle
Kevin> + (struct thread_info *);
Explaining that the thread handle is just some target-specific bytes
would be good.
Tom
next prev parent reply other threads:[~2019-03-05 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 2:24 [PATCH v2 0/5] Add python method gdb.InferiorThread.thread_handle Kevin Buettner
2019-02-28 2:30 ` [PATCH v2 1/5] Introduce target_ops method thread_info_to_thread_handle Kevin Buettner
2019-03-05 21:44 ` Tom Tromey [this message]
2019-02-28 2:31 ` [PATCH v2 2/5] Add python method InferiorThread.thread_handle Kevin Buettner
2019-03-05 21:48 ` Tom Tromey
2019-03-20 20:24 ` Kevin Buettner
2019-03-20 20:39 ` Tom Tromey
2019-03-20 20:48 ` Kevin Buettner
2019-02-28 2:32 ` [PATCH v2 3/5] Support buffer objects as handles in Inferior.thread_from_thread_handle() Kevin Buettner
2019-03-05 21:51 ` Tom Tromey
2019-02-28 2:34 ` [PATCH v2 4/5] Tests for gdb.InferiorThread.thread_handle Kevin Buettner
2019-03-05 21:54 ` Tom Tromey
2019-02-28 2:35 ` [PATCH v2 5/5] Documentation for python method InferiorThread.thread_handle Kevin Buettner
2019-02-28 18:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imwxq9ne.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox