Re: [PATCH+8.3?] Implement dump of mappings with ELF headers by gcore

Kevin Buettner
2019-04-25T21:04:37Z

On Thu, 25 Apr 2019 14:24:39 -0400
Sergio Durigan Junior <sergiodj@redhat.com> wrote:

> >> * linux-tdep.c (dump_mapping_p): Add new parameters "ADDR" and
> >> "OFFSET". Verify if current mapping contains an ELF header.
> >> (linux_find_memory_regions_full): Adjust call to
> >> "dump_mapping_p".
> >
> > I don't think that the double quotes enclosing ADDR and OFFSET are
> > needed here.
>
> Ah, OK. I tend to use them when I'm writing ChangeLog entries, but
> that's a matter of style. I'll remove them.

I think that quotes are appropriate when the actual names of the
parameters are used. But (as I recall) the GNU convention is to
change the names to all caps when referring to parameters in
documentation. ChangeLog entries are a form of documenation, so no
quotes.

So, had you said:

Add new parameters "addr" and "offset".

or:

Add new parameters ``addr'' and ``offset''.

...I would have been happy with the quotes.

But since you uppercased them, I don't think the quotes are needed
or even desired.

[...]
> > I think it's okay for master with the nits that I found fixed. I don't
> > have an opinion about including it in 8.3.
>
> Thanks, I pushed the patch below to master:
>
> 57e5e645010430b3d73f8c6a757d09f48dc8f8d5

I read your revised patch - didn't see any problems.

> I'll wait for another GM to give an opinion about including this into
> 8.3

If 8.3 is getting close, I think it should only go in master. But
if 8.3 still has some outstanding issues and testing yet to be done,
it might go in, especially if non-Fedora users are noticing problems.

Kevin