From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22643 invoked by alias); 3 Jun 2019 20:02:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22634 invoked by uid 89); 3 Jun 2019 20:02:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=events, mistaken X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jun 2019 20:02:19 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 89931A00051 for ; Mon, 3 Jun 2019 15:02:18 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Xt9uhT31E90onXt9uhV66H; Mon, 03 Jun 2019 15:02:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SyXjaqf4aIJVmj0+Eyadnef+DWNCvk0FVYOU9Mre+HQ=; b=DMGl+H+sZ2C68vK1bD8P3kIOCR qTeqs5clgnty2ON6rqk4VkbYvkWAOs9Zo74ckLE/PHHI5MDcK+WIFQMSWxYiXlToFSE10/4OLXmLX WJZXZU+J4zi9RD5CSxO3Rt9T+; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:60278 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hXt9u-000X2b-3w; Mon, 03 Jun 2019 15:02:18 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Give thread names in thread events, give Ada task names in more output. References: <20190518182306.22937-1-philippe.waroquiers@skynet.be> Date: Mon, 03 Jun 2019 20:02:00 -0000 In-Reply-To: <20190518182306.22937-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 18 May 2019 20:23:06 +0200") Message-ID: <87imtml9o6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00046.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> With this patch, we e.g. get: Philippe> [New Thread 0x7ffff701b700 (LWP 13891) "sleepers"] Philippe> [Switching to thread 2 (Thread 0x7ffff781c700 (LWP 13890) "sleepers")] Philippe> instead of: Philippe> [New Thread 0x7ffff701b700 (LWP 13918)] Philippe> [Switching to thread 2 (Thread 0x7ffff781c700 (LWP 13917))] Thanks. I'm mildly surprised this works at thread-announce time, since I thought the thread had to be created before it could be given a name. Maybe it is racy? (FWIW it is fine if it is.) Or maybe I'm mistaken and there's a way to name a thread before pthread_create. Philippe> +/* Return the string to display e.g. in "info threads"'s "Target Id" Philippe> + column, for TP. */ Philippe> + Philippe> +std::string Philippe> +thread_target_id_str (thread_info *tp); This should be "extern std::string thread_target_id_str (...);". However, could this just be a method on thread_info? I think that would be preferable. I think it's not much more work. Philippe> - target_pid_to_str (lp->ptid).c_str ()); Philippe> + thread_target_id_str (th).c_str ()); Are there spots calling target_pid_to_str that do not want to call the new function? thanks, Tom