From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89840 invoked by alias); 1 Jul 2019 17:26:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89832 invoked by uid 89); 1 Jul 2019 17:26:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.46.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Jul 2019 17:26:32 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id EFADD400D1F58 for ; Mon, 1 Jul 2019 12:26:30 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id i04UhArIQ4FKpi04UhPybb; Mon, 01 Jul 2019 12:26:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TjpTR5gQd0BeXryE4Kzl8WuY8qrXlyvVtLUlxHytT5k=; b=WSsyfMydEBdDayXoGtHu0hJxrZ +W7qqIy2U19SFq/dDJ3WRlDa9KCeOroVk+0zi+JticBpajzdBfvJ7hhzC94FEjTPVaxoz8VU4Z1F+ upmgvLJF1YxbCmOwexZAwtAta; Received: from 174-29-48-143.hlrn.qwest.net ([174.29.48.143]:55492 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hi04U-001bVj-O5; Mon, 01 Jul 2019 12:26:30 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output) References: <20190605020116.1550-1-tom@tromey.com> <1ee4bd6b-4cdf-f3a9-74af-0843bf123a8b@redhat.com> <87lfygi1x0.fsf@tromey.com> <32872d6a-15d6-9718-59ae-957694e114c9@redhat.com> <87imtjhj6b.fsf@tromey.com> <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> <87blzbep47.fsf@tromey.com> <2180f72f-da10-5333-90a1-666ba3bd145e@redhat.com> <87imtjbrmx.fsf@tromey.com> <871s056yjw.fsf@tromey.com> <87wohx5hir.fsf@tromey.com> <4e543ef2-eec3-b82c-a84a-a107e1ef2bc2@redhat.com> <5df7a829-1cff-3df4-f2d3-92076cdc4699@redhat.com> Date: Mon, 01 Jul 2019 17:26:00 -0000 In-Reply-To: <5df7a829-1cff-3df4-f2d3-92076cdc4699@redhat.com> (Pedro Alves's message of "Mon, 1 Jul 2019 14:05:55 +0100") Message-ID: <87imslpsxm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00018.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> static inline styled_string_s * Pedro> styled_string (const ui_file_style &style, const char *str, Pedro> styled_string_s &&tmp = {}) Nice trick -- I hadn't seen that one before! Pedro> Here's a patch implementing the idea above. I wrote this a couple Pedro> weeks ago, and at the time I felt more strongly about it. Is this Pedro> worth it? Yes, I think so. It removes some clutter. The expense is that the call is tricky and can't be relied on outside of an argument list, really; but on the other hand I don't expect these things to be used elsewhere. Tom