Re: [PATCH 05/14] Introduce dwarf2_unshareable and move die_type_hash

Tom Tromey
2020-02-21T22:43:50Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

We discussed this online but I thought I'd reply for the record.

>> In this patch, the new object is managed by the dwarf2_per_objfile.
>> However, by the end of the series, this will change.

Simon> So, in the end we'll have dwarf2_per_objfile, of which there will be only
Simon> one and will be shared between the objfiles, and dwarf2_unshareable of which
Simon> there will be N (for N objfiles), which won't be shared between the objfiles?

Yes.

Simon> I find it a bit confusing, because now the object called "per_objfile" is not
Simon> per objfile.

Yeah. In the cover letter I mentioned perhaps renaming this object.
That could be done with sed I suppose.

Tom