From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id F3C13385DC02 for ; Tue, 31 Mar 2020 19:35:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F3C13385DC02 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D0218116982; Tue, 31 Mar 2020 15:35:45 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6sNAVuu6Vg2b; Tue, 31 Mar 2020 15:35:45 -0400 (EDT) Received: from murgatroyd (97-118-117-21.hlrn.qwest.net [97.118.117.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 7E50411696A; Tue, 31 Mar 2020 15:35:45 -0400 (EDT) From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Avoid some copying in psymtab.c References: <20200320204935.19509-1-tromey@adacore.com> <20200320204935.19509-2-tromey@adacore.com> <93c13abe-c5ca-54e8-90e7-5d0fa171ef13@redhat.com> X-Attribution: Tom Date: Tue, 31 Mar 2020 13:35:45 -0600 In-Reply-To: <93c13abe-c5ca-54e8-90e7-5d0fa171ef13@redhat.com> (Pedro Alves's message of "Tue, 31 Mar 2020 18:46:05 +0100") Message-ID: <87imik9v1q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 19:35:46 -0000 >>>>> "Pedro" == Pedro Alves writes: Pedro> lookup_name_info has built-in support for psymtab-style symbol Pedro> names, with no parameter info. See psym_expand_symtabs_matching: Pedro> lookup_name_info lookup_name = lookup_name_in.make_ignore_params (); Pedro> I think doing the same in psym_lookup_symbol is likely to work Pedro> just the same, and avoid this new class. I knew about this but somehow I thought it only worked "one way". But, I've tried it and as far as I can tell it works fine and it simplifies the code, so I've made this change. Tom