From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.73]) by sourceware.org (Postfix) with ESMTPS id 4AE933887007 for ; Tue, 7 Apr 2020 15:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4AE933887007 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway24.websitewelcome.com (Postfix) with ESMTP id E7DD8BF0C for ; Tue, 7 Apr 2020 10:47:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id LqRKj2vfpXVkQLqRKjGdxO; Tue, 07 Apr 2020 10:47:02 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UBmCGMxw8E08k9ZMGIxeh4LolqhaSy4Ufz3y6M35ZZA=; b=t+4Qgg5Ks+eQix4o5t6Mg2A+Zd SxehC9DghRqMMNcGVFvH+FUx+N3SeSEHhQhoVa76S7j8eCmJs3wMjYfi9qnDDiXD1nr/5PkV2h3Lt w9yU17Z6n+ElVEfO8tlleGLd6; Received: from 174-16-110-145.hlrn.qwest.net ([174.16.110.145]:34152 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jLqRK-000AO6-Na; Tue, 07 Apr 2020 09:47:02 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb: small cleanups in dwarf2_psymtab constructors References: <20200407041914.1638066-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Tue, 07 Apr 2020 09:47:02 -0600 In-Reply-To: <20200407041914.1638066-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 7 Apr 2020 00:19:14 -0400") Message-ID: <87imib47t5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.110.145 X-Source-L: No X-Exim-ID: 1jLqRK-000AO6-Na X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-110-145.hlrn.qwest.net (murgatroyd) [174.16.110.145]:34152 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 15:47:05 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters Simon> constructor. Remove `addr` parameter from other constructor and Simon> add `per_cu` parameter. Simon> * dwarf2/read.c (create_partial_symtab): Update. Looks good to me. Thank you. Tom