From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [50.116.126.2]) by sourceware.org (Postfix) with ESMTPS id 551C13851C0C for ; Fri, 12 Jun 2020 03:25:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 551C13851C0C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id B7B24401AF64C for ; Thu, 11 Jun 2020 21:46:35 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id jaKDjbZQSQyTQjaKDjqvp1; Thu, 11 Jun 2020 22:25:49 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tqDI8t+WsUy8dU4dbiMDXmE4b4Esorj9HHro6J6cigg=; b=N3ZAfh4Z+wynwO/0AoIg0CJJ5G bkMJrvoZgMmmZV5zc6zTJatObTh1i24RIORZaCYZ0myko6bMs6GeFADLOJWJMkdd+6BvdK2TWOE33 kmvITDgBQbiIoJbxpfRvbXb1z; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:56638 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jjaKD-002j3f-Cn; Thu, 11 Jun 2020 21:25:49 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom de Vries , Simon Marchi , Pedro Alves , Tom Tromey , Simon Marchi via Gdb-patches Subject: Re: [PATCH v2 00/42] Share DWARF partial symtabs between objfiles References: <20200512210913.5593-1-simon.marchi@efficios.com> <875zcn1xwp.fsf@tromey.com> <5032927f-877b-100b-c3a7-55c78d3a7d7a@redhat.com> <058f6a56-4690-cfd8-ede4-a9bbafc85e1a@efficios.com> <28656eeb-c0b3-c601-f05c-14cfe5493a7e@redhat.com> <63f4d428-b0ec-26de-0265-31002b61f4dd@simark.ca> <2eefe6e4-567b-9742-0d66-e5a76771203d@simark.ca> <14342819-b0a1-12d1-8b35-e53500c5a67d@simark.ca> X-Attribution: Tom Date: Thu, 11 Jun 2020 21:25:48 -0600 In-Reply-To: <14342819-b0a1-12d1-8b35-e53500c5a67d@simark.ca> (Simon Marchi's message of "Tue, 9 Jun 2020 23:43:18 -0400") Message-ID: <87imfxm0cj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jjaKD-002j3f-Cn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (bapiya) [174.16.104.48]:56638 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2020 03:25:51 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> So this is a situation I hadn't accounted for: a BFD for which we have built the partial Simon> symtabs the first time, but has an index the second time. We probably just need a check Simon> for psymtabs in dwarf2_initialize_objfile, something like the Simon> patch below. This makes sense to me. Thank you for dealing with this bug & the other sharing bugs that have cropped up. Tom