From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3My3LfOsrV9QWgAAWB0awg (envelope-from ) for ; Thu, 12 Nov 2020 16:45:23 -0500 Received: by simark.ca (Postfix, from userid 112) id AE6301F08B; Thu, 12 Nov 2020 16:45:23 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5B0691E58D for ; Thu, 12 Nov 2020 16:45:23 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EEF86386F447; Thu, 12 Nov 2020 21:45:22 +0000 (GMT) Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.175]) by sourceware.org (Postfix) with ESMTPS id 3BB57386F02D for ; Thu, 12 Nov 2020 21:45:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3BB57386F02D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 48C0F400CE68C for ; Thu, 12 Nov 2020 15:45:20 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dKPAkqrjaiQiZdKPAkau6a; Thu, 12 Nov 2020 15:45:20 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dsYUS42AR0nPysNxaa+B7X8/i7oPwKL3GkDVjY6FQ0c=; b=biVTmGGPlWLYFT72ZTehBg2MVc Ee0NdPi9A4bQGMdDvg2mcPR87rZndDgLDJx5jY3IITGh03RLaz193Vu5gtFEFNnXtXGHnBaFrljDE Lbd0WY5wH9LsU9mnzXVRnlpDj; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:37728 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kdKP9-003UNm-UJ; Thu, 12 Nov 2020 14:45:19 -0700 From: Tom Tromey To: Keith Seitz via Gdb-patches Subject: Re: [PATCH 2/2] Exclude debuginfo files from "outside of ELF segments" warning References: <20201112205327.2733425-1-keiths@redhat.com> <20201112205327.2733425-2-keiths@redhat.com> X-Attribution: Tom Date: Thu, 12 Nov 2020 14:45:19 -0700 In-Reply-To: <20201112205327.2733425-2-keiths@redhat.com> (Keith Seitz via Gdb-patches's message of "Thu, 12 Nov 2020 12:53:27 -0800") Message-ID: <87imaab66o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kdKP9-003UNm-UJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:37728 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Keith" == Keith Seitz via Gdb-patches writes: Keith> The short of it is, the ELF program headers for debuginfo files are Keith> not suited to this particular use case. Consequently, the warning Keith> generated above really is useless and should be ignored. Keith> + /* Exclude debuginfo files from this warning, too, since those Keith> + are often not strictly compliant with the standard. See, e.g., Keith> + ld/24717 for more discussion. */ Keith> + if (!is_debuginfo_file (abfd) Keith> + && bfd_section_size (sect) > 0 && j == num_segments I didn't know about is_debuginfo_file, so I took a quick look, and it says: /* Determine if a bfd is a debuginfo file. Unfortunately there is no defined method for detecting such files, so we have to use heuristics instead. */ I wonder if gdb should just use its own idea here, though -- like if the objfile has a backlink, it is a separate debug file. I'm ok with this patch though. thanks, Tom