Re: [PATCH][gdb/exp] Fix assert when adding ptr to imaginary unit

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> 2021-01-28  Tom de Vries  <tdevries@suse.de>

Tom> 	PR exp/27265
Tom> 	* valarith.c (scalar_binop): Don't call complex_binop unless
Tom> 	arguments are either complex or can be casted to complex.

Thanks for doing this.

Tom> +  if ((type1->code () == TYPE_CODE_COMPLEX
Tom> +       && (type2->code () == TYPE_CODE_COMPLEX
Tom> +	   || type2->code () == TYPE_CODE_INT
Tom> +	   || type2->code () == TYPE_CODE_FLT))
Tom> +      || ((type2->code () == TYPE_CODE_COMPLEX
Tom> +	   && (type1->code () == TYPE_CODE_COMPLEX
Tom> +	       || type1->code () == TYPE_CODE_INT
Tom> +	       || type1->code () == TYPE_CODE_FLT))))
Tom>      return complex_binop (arg1, arg2, op);

Maybe it should use is_floating_type || is_integral_type instead?
is_scalar_type sounds like it should be right but does something really
different instead.  That function looks suspect to me.

This approach would still rule out fixed point.  I'm not sure if that's
ok to do though.

Also weirdly, is_fixed_point_type looks through TYPE_CODE_RANGE (seems
reasonable) but is_integral_type does not (seems wrong).

thanks,
Tom