From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ot8cGFWxIWBzTAAAWB0awg (envelope-from ) for ; Mon, 08 Feb 2021 16:47:01 -0500 Received: by simark.ca (Postfix, from userid 112) id 5006B1EF4F; Mon, 8 Feb 2021 16:47:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E62D41E4A3 for ; Mon, 8 Feb 2021 16:47:00 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 444DD389367C; Mon, 8 Feb 2021 21:47:00 +0000 (GMT) Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.46.107]) by sourceware.org (Postfix) with ESMTPS id 70810384B072 for ; Mon, 8 Feb 2021 21:46:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70810384B072 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id D5E4F4014B079 for ; Mon, 8 Feb 2021 15:39:33 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9EN0lmsmKiQiZ9EN0lB1WG; Mon, 08 Feb 2021 15:46:58 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lUA2Q63I5OJMR8rClFucTzBS/FVS1Bu53bl9aZYAmlA=; b=DNnC1Q9JWFLGWRMx1vJ2Vhfs93 hLTFSajYMZ6KELNZO/VMZ38uKulU2JEUuYdSkcfFzSpAlap6RGbYkDvctDOhX8+gK6pxwIZ0BdaEL EeYwWEywMxJmf0bQUGtVJezVe; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:38440 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9EMz-003PML-PH; Mon, 08 Feb 2021 14:46:57 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH 19/30] Add new location description access interface References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-20-Zoran.Zaric@amd.com> X-Attribution: Tom Date: Mon, 08 Feb 2021 14:46:57 -0700 In-Reply-To: <20201207190031.13341-20-Zoran.Zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Mon, 7 Dec 2020 19:00:20 +0000") Message-ID: <87im72dyge.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l9EMz-003PML-PH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:38440 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: Zoran> After adding interface for register and memory location access, a new Zoran> top level interface for accessing any location, described by the Zoran> dwarf_location class based objects, can now be defined. Zoran> Also, the address_type method is now needed to be outside of the Zoran> dwarf_stack_value class to allow creation of the DWARF generic type Zoran> independently of that class. Zoran> * dwarf2/expr.c (read_from_location): New function. Zoran> (write_to_location): New function. Zoran> (address_type): New function. Zoran> * dwarf2/expr.h (address_type): Exposed function. Zoran> + if (dynamic_cast (location) != nullptr) Zoran> + else if (auto register_entry Zoran> + = dynamic_cast (location)) Zoran> + else if (auto memory_entry = dynamic_cast (location)) I didn't read this patch too closely, but this kind of type-case should only be done when a virtual function is unsuitable. Tom