From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8E0DKDa3zGC4TQAAWB0awg (envelope-from ) for ; Fri, 18 Jun 2021 11:09:42 -0400 Received: by simark.ca (Postfix, from userid 112) id 94A0C1F163; Fri, 18 Jun 2021 11:09:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=MAILING_LIST_MULTI, RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EA4601E813 for ; Fri, 18 Jun 2021 11:09:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7F03D3835408 for ; Fri, 18 Jun 2021 15:09:41 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTPS id B0D50383F40B for ; Fri, 18 Jun 2021 15:09:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0D50383F40B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 639CB5600A; Fri, 18 Jun 2021 11:09:30 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bTKz8iSf+IYd; Fri, 18 Jun 2021 11:09:30 -0400 (EDT) Received: from murgatroyd (97-122-70-83.hlrn.qwest.net [97.122.70.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 0715656005; Fri, 18 Jun 2021 11:09:29 -0400 (EDT) From: Tom Tromey To: Christian Biesinger Subject: Re: [PATCH 2/2] Decode Ada types in Python layer References: <20210617191230.71887-1-tromey@adacore.com> <20210617191230.71887-3-tromey@adacore.com> X-Attribution: Tom Date: Fri, 18 Jun 2021 09:09:29 -0600 In-Reply-To: (Christian Biesinger's message of "Thu, 17 Jun 2021 16:10:01 -0500") Message-ID: <87im2bus46.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches , Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> + /* Ada type names are encoded, but it is better for users to see the >> + decoded form. */ >> + if (ADA_TYPE_P (type)) >> + { >> + std::string name = ada_decode (type->name (), false); Christian> Would type->demangled_name() do the right thing? (And should this Christian> respect the demangle option, maybe by calling type->print_name()?) I don't think there is a demangled_name method on type, only on symbol. It may make sense to add one, though this is really only an issue for Ada AFAIK. Tom