"show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array)

Pedro Alves
2022-04-20T11:31:27Z

On 2022-04-18 20:01, Pedro Alves wrote:
>
> (gdb) show remote X-packet
> Support for the 'p' packet on newly created remote targets is "disabled".
>
> and of course:
>
> (gdb) set remote X-packet disabled
> "on", "off" or "auto" expected.
>
>
> Also, BTW, err, why do we talk about the 'p' packet if the command is about
> the X packet? That's busted. Seems like a preexisting issue in current master.

I bisected this, and found out it was a regression introduced by this commit:

8579fd136a614985bd27f20539c7bb7c5a51287d is the first bad commit
commit 8579fd136a614985bd27f20539c7bb7c5a51287d
Author: Andrew Burgess <aburgess@redhat.com>
Date: Mon Nov 8 14:58:46 2021 +0000

gdb/gdbsupport: make xstrprintf and xstrvprintf return a unique_ptr

The motivation is to reduce the number of places where unmanaged
pointers are returned from allocation type routines. All of the
callers are updated.

There should be no user visible changes after this commit.

This commit is present in the GDB 12 branch and not in GDB 11, so it's a regression there.