Re: [PATCH v2 2/3] gdb: Add per-remote target variables for memory read and write config

Tom Tromey
2022-04-18T14:56:31Z

>>>>> Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org> writes:

> This patch adds per-remote target variables for the configuration of
> memory read- and write packet size. It is a further change to commit
> "gdb: Make global feature array a per-remote target array" to apply the
> fixme notes described in commit 5b6d1e4 "Multi-target support".

Thank you for the patch.

> + const char* target_type = get_target_type_name (remote != nullptr);

The "*" should be after the space.

> + const memory_packet_config* config,

Here too.

> + memory_packet_config* config = &memory_write_packet_config;

And here... there are a few of these.

This ok with these nits fixed, you don't have to re-send the patch.

Tom