[PATCH v2 0/3] Apply fixme notes for multi-target support

Christina Schimpe via Gdb-patches
2022-03-29T13:12:36Z

Hi all,

This is the V2 for the series "Apply fixme notes for multi-target support" based
on the feedback of Tom and Andrew. I am sorry that it took so long to get to.

V1 of this series can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-January/185091.html.

Changes for patch #1:
* Remove obsolete 'remote_state *' parameters.
* Extract packet number using the 'context' attached to the command.
* Enhance commit message.
* Adapt the logging for the 'show remote PACKET-NAME' and added logging for the
'set remote PACKET-NAME' commands for the new command behavior. I chose a very
similar logging to the one Andrew suggested in the review for V1 of this series.
* Adapt tests for the new logging.
* Add NEWS entry.
* Update the documentation.
* Add comments.
* Move smaller functions inside the new struct remote_features.

Changes for patch #2:
* Adapt the behavior of the 'show remote memory-read/write-packet-size' commands
such that they behave similar to the previous patch e.g.
"The show command always displays the current remote target's
configuration. If no remote target is selected the default
configuration for future connections is shown".
* Adapt the commit message accordingly.
* Adapt the logging for the 'set remote memory-read/write-packet-size' and added
logging for the 'set remote memory-read/write-packet-size' commands.
* Adapt tests for the new logging.
* Add NEWS entry.
* Update the documentation.
* Add comments.
* Cosmetic changes.

I did not make any changes to patch #3 of this series
(https://sourceware.org/pipermail/gdb-patches/2022-January/185090.html).
Reasoning for this is described in
https://sourceware.org/pipermail/gdb-patches/2022-January/185560.html.
Please let me know if you have comments on the patch or if it is acceptable as is.

Thanks,

Christina

Christina Schimpe (3):
gdb: Make global feature array a per-remote target array
gdb: Add per-remote target variables for memory read and write config
gdb: Remove workaround for the vCont packet

gdb/NEWS | 25 +
gdb/doc/gdb.texinfo | 24 +-
gdb/remote.c | 1469 +++++++++--------
gdb/testsuite/gdb.base/cond-eval-mode.exp | 9 +-
gdb/testsuite/gdb.base/dprintf.exp | 5 +-
gdb/testsuite/gdb.base/find-unmapped.exp | 5 +-
.../gdb.base/hbreak-in-shr-unsupported.exp | 4 +-
gdb/testsuite/gdb.base/remote.exp | 45 +-
.../gdb.multi/multi-target-info-inferiors.exp | 6 +-
gdb/testsuite/gdb.multi/multi-target.exp.tcl | 8 +-
.../connect-without-multi-process.exp | 4 +-
.../gdb.server/exit-multiple-threads.exp | 9 +-
gdb/testsuite/gdb.server/ext-restart.exp | 5 +-
gdb/testsuite/gdb.server/ext-wrapper.exp | 5 +-
gdb/testsuite/gdb.server/server-exec-info.exp | 5 +-
gdb/testsuite/gdb.server/server-kill.exp | 4 +-
.../gdb.server/stop-reply-no-thread-multi.exp | 8 +-
.../gdb.server/stop-reply-no-thread.exp | 9 +-
.../process-dies-while-handling-bp.exp | 9 +-
gdb/testsuite/gdb.trace/change-loc.exp | 4 +-
gdb/testsuite/gdb.trace/qtro.exp | 6 +-
21 files changed, 976 insertions(+), 692 deletions(-)

--
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928