Re: "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array)

Pedro Alves
2022-04-21T18:20:26Z

On 2022-04-21 17:28, Andrew Burgess wrote:
> Andrew Burgess <aburgess@redhat.com> writes:
>
>> Pedro Alves <pedro@palves.net> writes:
>>
>>> On 2022-04-21 11:25, Andrew Burgess wrote:
>>>> Pedro Alves <pedro@palves.net> writes:
>>>>>
>>>>> This commit is present in the GDB 12 branch and not in GDB 11, so it's a regression there.
>>>>
>>>> Sorry for the regression. I took a look at the code and I honestly have
>>>> no idea why I thought the code in the above commit would work :-/
>>>>
>>>
>>> No worries, happens all the time to me. :-)
>>>
>>>> Below is a patch that should fix this issue. I probably should write a
>>>> test to go along with it, but thought I'd share this for feedback first.
>>>>
>>>> Let me know what you think,
>>>
>>> LGTM. Thanks for fixing it.
>>
>> Thanks, I'll just let a test run complete, and push this later today.
>
> I pushed the following patch to master and gdb-12-branch.

Perfect, thanks for adding the testcase.