From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id akW1MJA5YWKlWQEAWB0awg (envelope-from ) for ; Thu, 21 Apr 2022 07:01:36 -0400 Received: by simark.ca (Postfix, from userid 112) id B9EE51E15F; Thu, 21 Apr 2022 07:01:36 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=PVkGIXam; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4ED271E01D for ; Thu, 21 Apr 2022 07:01:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9485138425BE for ; Thu, 21 Apr 2022 11:01:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9485138425BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1650538895; bh=vNAAvWxE03In95k4daIvxh1dONDKIYPZj66ouwtK1dw=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PVkGIXamWk+9m/wlxVHQTL7Vkq/YxMJlzRCvuTwdpmVaEQh2W71Nuzd6xrtHKt1xA /ywCHM/bcBui9mh52MBr1ekLl3ME8CoF8S2alXvoGz7E0AM3IbyYuL1GWxpLFSOfpS zT5JHQjKPq9Sv//wdqg4L8CrsvkW8AhuQEomI9UU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 029B13856DCC for ; Thu, 21 Apr 2022 11:01:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 029B13856DCC Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-537-oaHVoQMTNVSMii5TUrlu9w-1; Thu, 21 Apr 2022 07:01:15 -0400 X-MC-Unique: oaHVoQMTNVSMii5TUrlu9w-1 Received: by mail-ej1-f72.google.com with SMTP id 13-20020a170906328d00b006982d0888a4so2295778ejw.9 for ; Thu, 21 Apr 2022 04:01:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=vNAAvWxE03In95k4daIvxh1dONDKIYPZj66ouwtK1dw=; b=0n8ariCtMgK0xDrRZT0kABYWUdkmjSjU+AYnkAVBN26YuQcCntEShfA7a74MMsmAOy eWtUbAvW3pNdKw4ricH64VfPj5qk8VQKqD2JDkD8NaKVAN0enVP8U15EGbOICQ3q/aAr yAlBWCzvUSIAgGGeVG4YfXGU+MRIlQPX9WkccBVXUk0Ia7+sYsBCNcNzmE5Z8ckjwQxy 4RCC5cx/xyryrh1QColMA2wTtaLvJY+pUJhOE8iUo8x24RzQPY3TZal9buIGds89JiX1 L91Tx6GHlSQIyLTEHklaZ5CFlAkYmQkkjDC0reEJXGJ5kCfvL2oh6vWtLQde3F/RjqNz T0HA== X-Gm-Message-State: AOAM532L8NvTKUMeYAtwCqbpDUErp5hB+PH2VSZqw/F6wqlpdzCLUv6u 9YFPqz6kO75KU7YIvNWZbtWNR3QecfrmAE9W2k/kFnudzMOGuUPUnEeVeVT14THtyu8CeaXkpYh /yjOVEFxU0osyQqnah7wbDg== X-Received: by 2002:a50:ab51:0:b0:41d:7b42:e34 with SMTP id t17-20020a50ab51000000b0041d7b420e34mr28167846edc.313.1650538874471; Thu, 21 Apr 2022 04:01:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVJjAW6ELItDQiyFyYzKEDflQ/EclGsj7J+Wt9t+bP0p3mtWyOSv7VJ2sGVW8NElWLRfakcw== X-Received: by 2002:a50:ab51:0:b0:41d:7b42:e34 with SMTP id t17-20020a50ab51000000b0041d7b420e34mr28167783edc.313.1650538873865; Thu, 21 Apr 2022 04:01:13 -0700 (PDT) Received: from localhost (92.40.168.187.threembb.co.uk. [92.40.168.187]) by smtp.gmail.com with ESMTPSA id cr10-20020a056402222a00b0041d918fdf99sm11438623edb.85.2022.04.21.04.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 04:01:13 -0700 (PDT) To: Pedro Alves , Christina Schimpe , gdb-patches@sourceware.org Subject: Re: "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array) In-Reply-To: <6fb9a140-0163-ce56-ac78-f5bf3f1b7795@palves.net> References: <20220329131158.3970228-1-christina.schimpe@intel.com> <20220329131158.3970228-2-christina.schimpe@intel.com> <08fd8bbf-c44e-7313-d7b3-7b0770c2c7d4@palves.net> <7c319441-067e-6f5c-cf80-84d696c9236e@palves.net> <87mtgerawv.fsf@redhat.com> <6fb9a140-0163-ce56-ac78-f5bf3f1b7795@palves.net> Date: Thu, 21 Apr 2022 12:01:10 +0100 Message-ID: <87ilr2r98p.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Pedro Alves writes: > On 2022-04-21 11:25, Andrew Burgess wrote: >> Pedro Alves writes: >>> >>> This commit is present in the GDB 12 branch and not in GDB 11, so it's a regression there. >> >> Sorry for the regression. I took a look at the code and I honestly have >> no idea why I thought the code in the above commit would work :-/ >> > > No worries, happens all the time to me. :-) > >> Below is a patch that should fix this issue. I probably should write a >> test to go along with it, but thought I'd share this for feedback first. >> >> Let me know what you think, > > LGTM. Thanks for fixing it. Thanks, I'll just let a test run complete, and push this later today. Thanks, Andrew