From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id F1qdHEENK2UI8S0AWB0awg (envelope-from ) for ; Sat, 14 Oct 2023 17:50:57 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=PvjGDqeq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 65B681E0C1; Sat, 14 Oct 2023 17:50:57 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4EF561E091 for ; Sat, 14 Oct 2023 17:50:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA3463858408 for ; Sat, 14 Oct 2023 21:50:54 +0000 (GMT) Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id D56E33858C5F for ; Sat, 14 Oct 2023 21:50:40 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D56E33858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697320244; cv=none; b=dnVIM55Oh2OaGvCyldXu7Ww1wFxx8Y206djFWA/cQ1VjtwCbLOqafkdU/i9jKLDHCTUPNkdEocGMQMyX22fjr/IhzT8dBzxyKdJaOtyCf66T0SmqUz8dPmFh1qoX37jxBWgr9RhpLyVzCuv0sFzgPP4ka+Ya7FuocQE8Wr3ZVJc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697320244; c=relaxed/simple; bh=GH89Aj/piajNXV4pJnfzACbsnC2CbPfa/75N16mry9I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IqZarOlGF6xUjHWjqBuuiBBnxOw5MtelxrHvUIPpx2PjUEmt4NNF8giBy+UXtFcin/c14B+qGvGhWjefNwiRrA9yNOnjqaR+CuHY3/cC44LJN49diTsg9oif+gwttpSrU8BUqfrYpYKJE65hScXGRQgjrLJcWWzLv1eJmUaZcM0= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D56E33858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTP id rewZqf8IKytxcrmWtqnrXQ; Sat, 14 Oct 2023 21:50:39 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rmWsqCkbkcjX4rmWtqSsK3; Sat, 14 Oct 2023 21:50:39 +0000 X-Authority-Analysis: v=2.4 cv=Z/b/oVdA c=1 sm=1 tr=0 ts=652b0d2f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=zd2uoN0lAAAA:8 a=TgDO83QlvdvUZmn5oqsA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5FAYZ9A4kI4d+7BQq/5Er08atL7VtLjDh2JUR3x1Cqo=; b=PvjGDqeq9dHEaMV8lBOfVQrCOd bqQXmPhz1bJyVjmoTUkEE533dgwe0ETPb5wmgrcKtsF/HvARe7h2xIeJRKv5zSNExbFap20QSk/Vb jIEkJg6xGcNqNzycML9hnNQV4; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:51534 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qrmWs-003LIT-1g; Sat, 14 Oct 2023 15:50:38 -0600 From: Tom Tromey To: Lancelot Six Cc: Subject: Re: [PATCH 06/11] gdb: Use std::string_view instead of gdb::string_view References: <20231013144418.3180617-1-lancelot.six@amd.com> <20231013144418.3180617-7-lancelot.six@amd.com> X-Attribution: Tom Date: Sat, 14 Oct 2023 15:50:37 -0600 In-Reply-To: <20231013144418.3180617-7-lancelot.six@amd.com> (Lancelot Six's message of "Fri, 13 Oct 2023 14:44:13 +0000") Message-ID: <87il78x49e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qrmWs-003LIT-1g X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (prentzel) [71.211.130.31]:51534 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLQToRmMjjTxxe+ThU+M5gbWvCSr/pfLTvRc0LrCuWXue+3LZelw+fW63iEYVka3BwFelWFXXR1qf+pWOc3WoUwI+cx5sPJ33cbi1RYylWrqN8ouzi7/ yqW18XZ0D3WxcQh6eE62lpW1A0KK7VwbqLr1v+NcW48bHVsAtzTroTYCnvexdU9oRfDgWxU/AfaAqW1eAnSrNrHibxKewAtG3TU= X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Lancelot" == Lancelot Six writes: Lancelot> Given that GDB now requires a C++17, replace all uses of Lancelot> gdb::string_view with std::string_view. Lancelot> This change has mostly been done automatically: Lancelot> - gdb::string_view -> std::string_view Lancelot> - #include "gdbsupport/gdb_string_view.h" -> #include Lancelot> The implementation and tests of gdb::string_view are unchanged, they will Lancelot> be removed in a following patch. IIRC there are some spots using gdb::string_view that construct one with nullptr, which isn't allowed by std::string_view. Maybe a test run using the libstdc++ debug mode would detect this? Tom