Re: [PATCH v5 1/5] gdb: make gdbarch store a vector of frame unwinders

Tom Tromey
2024-10-17T22:54:31Z

Guinevere> I am not a big fan of the registry subsystem, so I would prefer to
Guinevere> keep it as a simple vector. However, if you are concerned about the
Guinevere> opaqueness change, Tromey, I can try to make it more opaque. I just
Guinevere> personally find that registry tends to make the code too opaque for
Guinevere> programmers as well as the program itself :-)

I think gdbarch is exposed to a lot of tdep code, and this code in
particular to do questionable things. So, preserving some opacity makes
sense to me.

Guinevere> So if you want more separation, I would personally prefer to look into
Guinevere> only receiving a copy of the unwinder list, and gdbarch is responsible
Guinevere> for adding and removing things. Just let me know and I can give it a
Guinevere> shot

I think it would be more worthwhile to understand your objections to the
registry. It seems to me that switching back to using it is just a
couple of lines of code, so it makes me think there must be some pretty
strong reason.

Tom