Re: [PATCH v5 4/5] gdb: introduce ability to disable frame unwinders

Guinevere Larsen
2024-10-04T17:58:14Z

On 10/2/24 3:10 AM, Eli Zaretskii wrote:
>> From: Guinevere Larsen <guinevere@redhat.com>
>> Cc: Guinevere Larsen <blarsen@redhat.com>
>> Date: Tue, 1 Oct 2024 15:42:34 -0300
>>
>> +maintenance set dwarf unwinders (on|off)
>> + This command has been removed because the same functionality can be
>> + achieved with maint frame-unwinder (enable|disable) DEBUGINFO.
>> +
>> +maintenance show dwarf unwinders
>> + This command has been removed since the functionality can be achieved
>> + by checking the last column of maint info frame-unwinders.
> What is our procedure for removing maintenance commands? Are we okay
> with unconditionally removing them in the same GDB release where we
> introduce their replacements, or do we want to keep them for some time
> for the benefit of those who use them in some scripts?
While chatting to Andrew off-list I asked about this, and he said we
don't offer any longevity guarantees for maintenance commands, and
historically this has been done before, all that was needed was
mentioning in the news file how to get the new functionality.
>
> The documentation parts are approved, thanks.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
>
Thanks for the review!

--
Cheers,
Guinevere Larsen
She/Her/Hers