Re: [PATCH v5 1/5] gdb: make gdbarch store a vector of frame unwinders

Tom Tromey
2024-10-04T18:37:42Z

>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:

Guinevere> Seeing as a future patch of this series wants to refactor the
Guinevere> frame_unwind struct to use inheritance, and we'd like to not restrict
Guinevere> the future derived classes on what destructors are allowed. In
Guinevere> preparation for that change, this commit adds an std::vector to gdbarch
Guinevere> to store the unwinders in.

Using a vector is fine, but I still think that this approach
makes gdbarch mildly less opaque. That is, now code anywhere can modify
the unwinder list in any way; whereas currently this is constrained to
the interface provided by frame-unwind.c.

Tom