Re: [PATCH] gdb/guile: add get-basic-type

[Andrew Burgess <aburgess@redhat.com>]

Kevin Buettner <kevinb@redhat.com> writes:

> On Sun,  6 Oct 2024 20:40:23 +0100
> Andrew Burgess <aburgess@redhat.com> wrote:
>
>> A question was asked on stackoverflow.com about the guile function
>> get-basic-type[1] which is mentioned in the docs along with an example
>> of its use.
>> 
>> The problem is, the function was apparently never actually added to
>> GDB.  But it turns out that it's pretty easy to implement, so lets add
>> it now.  Better late than never.
>> 
>> The implementation mirrors the Python get_basic_type function.  I've
>> added a test which is a copy of the documentation example.
>> 
>> One issue is that the docs suggest that the type will be returned as
>> just "int", however, I'm not sure what this actually means.  It makes
>> more sense that the function return a gdb:type object which would be
>> represented as "#<gdb:type int>", so I've updated the docs to show
>> this output.
>> 
>> [1] https://stackoverflow.com/questions/79058691/unbound-variable-get-basic-type-in-gdb-guile-session
>> ---
>>  gdb/doc/guile.texi                       |  2 +-
>>  gdb/guile/lib/gdb/types.scm              | 19 +++++++++++++++++++
>>  gdb/testsuite/gdb.guile/types-module.cc  |  4 ++++
>>  gdb/testsuite/gdb.guile/types-module.exp |  5 +++++
>>  4 files changed, 29 insertions(+), 1 deletion(-)
>
> LGTM.
>
> Reviewed-by: Kevin Buettner <kevinb@redhat.com>

I've gone ahead and pushed this patch.  If there's any post-commit
feedback then I'm happy to address it.

Thanks,
Andrew