From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LnMPFYypQGduCDsAWB0awg (envelope-from ) for ; Fri, 22 Nov 2024 10:55:56 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IyX5R1DG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1BBFA1E25F; Fri, 22 Nov 2024 10:55:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 759F71E1CC for ; Fri, 22 Nov 2024 10:55:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0862D3858416 for ; Fri, 22 Nov 2024 15:55:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0862D3858416 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IyX5R1DG Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 268B53858416 for ; Fri, 22 Nov 2024 15:55:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 268B53858416 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 268B53858416 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732290913; cv=none; b=nrOipvTne3vobbbNQf5LHgY27YxKrLdd9zZnyfDC882uc+kZx9MtVI/jl5mx/vJzdrzuKarBvs9cG1ZIe3J/xYcx3QHU8J1JOMa4nA7W9avny52WVEk488RX32Js3ht2oqhb8UYCInUQBd8rO8ND8XqrbG+NHO722m/oJ+zIqSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732290913; c=relaxed/simple; bh=gMHSRVoiwYA0ffCpecsXsO0Qtb7aAjOkt7I+ALConWk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OBYBRuDx6MVXUve3MfsQsouccJK6iyFXn2XxYkYlurpodHtZg4yzAbV2N7pubUVq5a1OU+XqNYQYTjw3ybVSBwTsrDrgBIDMBOIPjMzWZJZ53q4CUh7bUr4Z2MviQWQqJo8/In63nY4m7quFznW5pRxPWJ7brSnIpbmIlqm1Gt0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 268B53858416 Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id EROitGXvDumtXEW00tBnaY; Fri, 22 Nov 2024 15:55:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id EVzztF2MMCgT6EVzzthkc7; Fri, 22 Nov 2024 15:55:11 +0000 X-Authority-Analysis: v=2.4 cv=XvwxOkF9 c=1 sm=1 tr=0 ts=6740a95f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VlfZXiiP6vEA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=-TgpxQuZUK-bE0X6NxkA:9 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=C7eOqTu4wB7Y6VlI6Scryqhz745yrZa5ISy9WxoxwBY=; b=IyX5R1DGphZChVOJetgYjWgCpU q+Y9IbNxQ3nW/L0+BN4bTLRUnj+rTX11pVyLcVdaKHmcKsi9NMf5Cr26qZaxRRxu9L4HXUwYrkWvP RZ+N88xVrOvtTe3C9RVoQadqc; Received: from 97-122-113-155.hlrn.qwest.net ([97.122.113.155]:51542 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tEVzz-003d5l-0B; Fri, 22 Nov 2024 08:55:11 -0700 From: Tom Tromey To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v5] gdb: Introduce RAII signal handler setter In-Reply-To: <20241118195717.783180-1-guinevere@redhat.com> (Guinevere Larsen's message of "Mon, 18 Nov 2024 16:57:17 -0300") References: <20241118195717.783180-1-guinevere@redhat.com> X-Attribution: Tom Date: Fri, 22 Nov 2024 08:55:10 -0700 Message-ID: <87iksfs1pd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.113.155 X-Source-L: No X-Exim-ID: 1tEVzz-003d5l-0B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-113-155.hlrn.qwest.net (murgatroyd) [97.122.113.155]:51542 X-Source-Auth: tom+tromey.com X-Email-Count: 17 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDDrusaLSVDdJHYmSy/lOM/nDiXxOh7exUtnJgme8GRqTY79/I2LZNvR2KjA/OOTm4V+GHPlXoXTWkc0Sp8bDW0epn3esvqzFOHh9zXqS3HQlLZxEAx6 r6J62PhgiE86i6r+yV3gB/V5yYrK36aEGor0sadIrf6MpRW6dAd0NmntKBEfX6ILsKO5oyQr/W/6MKF2DHGjDgOUFCc1o1vP8Z4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Guinevere" == Guinevere Larsen writes: Guinevere> +#if defined (HAVE_SIGACTION) Guinevere> + struct sigaction m_prev_handler; Guinevere> +#else Guinevere> + typedef sighandler_t m_prev_handler; Guinevere> +#endif That #else branch looks wrong, I would guess s/typedef// gnulib says sigaction isn't on mingw, so maybe a mingw cross-hosted build would show the problem. Tom