From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WG5MM27uhmfoSg8AWB0awg (envelope-from ) for ; Tue, 14 Jan 2025 18:08:30 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YUuf5M0q; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CE6221E100; Tue, 14 Jan 2025 18:08:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3E9D81E05C for ; Tue, 14 Jan 2025 18:08:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AFBE4385C41A for ; Tue, 14 Jan 2025 23:08:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFBE4385C41A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YUuf5M0q Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id DD3A6385C407 for ; Tue, 14 Jan 2025 23:08:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD3A6385C407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DD3A6385C407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736896082; cv=none; b=NBxeMg1iUgbLsMeUzZmmfsH36N45VrM2iKbS8fo8OokfiwW4uv2tg2FuCW0SGa5diP5qrYW/iI4MQxKvPjXAHUqLhuLa5wzCuvaldOI0jtduUI/y2CguaO/zjCN4gHiSSJ6DyRawM2BfOu40nS1idbZn8T2Ytr9Wuh7gpTDukLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736896082; c=relaxed/simple; bh=7vWePbwMHTkio92LHap92q6mSvcTvZILfPDvRBs6w1E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UC8O6d9jCLdnSV+OTcg+nFjZf2X8ymnoRKlZCI6P46D8ZqV6v+ycVp6A8qCCk9iuQJVNzpQ5S6yMUcvtl7BmbSYMGdgYfEiMMy7Ret+1QCA3YgZdEzu9TL1E96qyLAoO32ffSSjDaUZvmE8k84GNZ9zFr49c/6KOi2twynaTinM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD3A6385C407 Received: from eig-obgw-6006a.ext.cloudfilter.net ([10.0.30.182]) by cmsmtp with ESMTPS id Xox9tPw15dz4NXq0vtstft; Tue, 14 Jan 2025 23:08:01 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Xq0utjBdSfoYEXq0utIH1Y; Tue, 14 Jan 2025 23:08:01 +0000 X-Authority-Analysis: v=2.4 cv=GtlE+F1C c=1 sm=1 tr=0 ts=6786ee51 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdSt8ZQiCzkA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=4CBnLoZPcyEBg4gT_FAA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pQ3rZ/r0MtrmKJd88weP3w2wxG20/oL5xqYw0zer6YA=; b=YUuf5M0q9zsoqYd+1L4GwnQKtA 9dIJRMbHdcjao5R2/rhxC9m9EOMk5Q/M0n/E28ytMkg1h+BcdR1isxYFid/YhaqFBZieuRATjBvr2 mO+LX595oSGsAk8ybNVnhUtSz; Received: from 97-118-36-154.hlrn.qwest.net ([97.118.36.154]:50792 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tXq0t-000xER-1r; Tue, 14 Jan 2025 16:07:59 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Andrew Burgess , gdb-patches@sourceware.org, Guinevere Larsen Subject: Re: [PATCH] gdbserver: convert program_args to a single string In-Reply-To: (Simon Marchi's message of "Tue, 14 Jan 2025 12:34:49 -0500") References: <87ldvdqpgb.fsf@tromey.com> X-Attribution: Tom Date: Tue, 14 Jan 2025 16:07:57 -0700 Message-ID: <87ikqhuh82.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.36.154 X-Source-L: No X-Exim-ID: 1tXq0t-000xER-1r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-36-154.hlrn.qwest.net (prentzel) [97.118.36.154]:50792 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfC5nZm24upYsYclWa/4QXHrsdJXXe9gYpZ6EuUa6RNPa4jDDd0a8OU2jZfE7M87a+SJ9zwIea+AgP20F2FE3Un8UAgMOPNE567nRHsYaUh8AI/YP1ALK 9oIHMFtpNl1Dexp92W4WtF3+U1yl3MQWZYhxAPoDkilAnl8tQd8v/NGU2mbNAD0Cjdnp4GUyMjsp5Cu+YQYFjv/IH1ZYBbMAhvQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: The approach I normally take is: Simon> struct base Simon> { Simon> /* 1 */ Simon> virtual void method (); Simon> }; ... documentation of the contract here. Simon> -- base.c Simon> /* 2 */ "See blah.h" here. Simon> struct impl : public base Simon> { Simon> /* 3 */ Simon> void method () override; Nothing here. Simon> /* 4 */ Simon> void impl::method () Not sure what I do here in practice. Simon> - #1 is where you should have the documentation about the behavior of Simon> `method` Simon> - #2 would be the typical /* See base.h. */, although I find these Simon> comments a bit useless Yeah they are. Over time I've kind of come around to Doug's view which was that the comments should be on the implementations. But oh well, kind of late to change that. Simon> - I never know what to put for #4, you can't put /* See impl.c. */, Simon> since you're already in impl.c. Again, I feel like a "See whatever" Simon> comment is a bit useless: if you know C++, you know you need to go Simon> look at the declaration of struct/class `impl`. Yeah. We could just leave off the comment here I suppose. Tom