From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UaciIjGij2cbZhYAWB0awg (envelope-from ) for ; Tue, 21 Jan 2025 08:33:37 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=bLRKFuXZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 730591E100; Tue, 21 Jan 2025 08:33:37 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EBF591E08E for ; Tue, 21 Jan 2025 08:33:35 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6B07D3857365 for ; Tue, 21 Jan 2025 13:33:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B07D3857365 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=bLRKFuXZ Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 994063857B98 for ; Tue, 21 Jan 2025 13:32:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 994063857B98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 994063857B98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737466377; cv=none; b=KsYlDgIBNVuUYYxV5+jkR1kN31nYv0VT+hG6+tt8MuxQqqZJo80tgiI2nrhB0Zf6wLay3HtbZvirjoLZgmfHgaCWvlRz2ZdngseKBrQny5rOcXILzRofkq0Ks2rmkWp6ODKDA7MjIrEO749ID88g4XV98EMVVTSoah2gr/RZ3G4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737466377; c=relaxed/simple; bh=T/WrPM+vNujzytrCqnN5oi8rXkB4RrEehxXaO/FcEU0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ETsfcUDogJryLITAyMTyr5ALvK98jbFaCRhOokxY/QtxUoi34kQi0kNQBd8aWuUo/rptrllmblAXawXYJKgsrcZBOado8oOZx2fwlFzfql+fagaPt23k/uTvlcy+zjDXfDj0gVtTeaWq9aRfJPAIDUizYvZepxk5K0NqEk6SLbI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 994063857B98 Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id aDlWtKrQhXshwaENFtycMR; Tue, 21 Jan 2025 13:32:57 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id aENEt3qxNdQylaENEt0rWN; Tue, 21 Jan 2025 13:32:56 +0000 X-Authority-Analysis: v=2.4 cv=McOnuI/f c=1 sm=1 tr=0 ts=678fa208 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdSt8ZQiCzkA:10 a=ItBw4LHWJt0A:10 a=ZANiP01XgbaHGWltPwMA:9 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iGyvaYG5qcZvprRDpjT8oKqpCiut8D525Zy4byijt2U=; b=bLRKFuXZuol44O2BIaYL5L3v7Z LzPqBRPmtMBTEElccKkFIi5O2DhHTsD8GLMtWqw0etXg9SVuhyCWb12Xre9qGV/auflBxaQTbieuo Gpqe08NfVcnAizIIjgSz+qRaX; Received: from 97-118-36-154.hlrn.qwest.net ([97.118.36.154]:60036 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1taEND-002jpI-30; Tue, 21 Jan 2025 06:32:56 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] [gdb/symtab] Fix dwarf version of DWO TU In-Reply-To: <20250120085723.5693-1-tdevries@suse.de> (Tom de Vries's message of "Mon, 20 Jan 2025 09:57:23 +0100") References: <20250120085723.5693-1-tdevries@suse.de> X-Attribution: Tom Date: Tue, 21 Jan 2025 06:32:55 -0700 Message-ID: <87ikq8pa0o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.36.154 X-Source-L: No X-Exim-ID: 1taEND-002jpI-30 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-36-154.hlrn.qwest.net (murgatroyd) [97.118.36.154]:60036 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDsOYVZCvGn1WXTu8BdRzL1D/ddPniNuJeO2GroEQrkopROux/ej9U8ED8gnlq8mPZ/+WxtmvDmRJFEHE7g45LwnDF1gg6OEmB1xA/17cZTTiDDdwbTo XJUz4+kHvI+cxnSAyi55/Q/hW5Ho48L5MBJ49fZTZwr7M8Rp+hSFBGiUmttvbBhzaj+rT+clr9YkvedfDhxdiEeh44LZwLZI9RI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> When running test-case gdb.ada/access_tagged_param.exp with target board Tom> fission, we run into: Tom> ... Tom> (gdb) break pck.adb:19^M Tom> gdb/dwarf2/read.h:289: internal-error: version: \ Tom> Assertion `m_dwarf_version != 0' failed.^M Tom> ... Tom> - && (cu->per_cu->version () == 2 Tom> + && (cu->header.version == 2 All the stuff in this area seems kind of horrible to me. Like, first of all, how can this even fail? It seems like the CU version should be set when setting up the reader. And if not, what's gone wrong there? Relatedly, can the other callers of version() fail in the same way? Finally there aren't really that many callers of this method so I wonder if it can be removed, maybe making this code less fragile. Looking at it, I feel pretty sure if I needed a version check I'd probably write code to call this method but ... maybe that's unsafe? Tom